Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2885453004: [ObjC ARC] Converts ios/chrome/test/earl_grey:hooks to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 7 months ago
Reviewers:
baxley
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/test/earl_grey:hooks to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2885453004 Cr-Commit-Position: refs/heads/master@{#472538} Committed: https://chromium.googlesource.com/chromium/src/+/0182ad5525a53fbd14266e3f044ad32bddc6faa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/test/earl_grey/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/earl_grey/eg_tests_hook.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
liaoyuke
Hey Mike, PTAL. Thank you very much!
3 years, 7 months ago (2017-05-17 15:25:18 UTC) #6
baxley
lgtm
3 years, 7 months ago (2017-05-17 16:27:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885453004/1
3 years, 7 months ago (2017-05-17 16:33:57 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 19:44:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0182ad5525a53fbd14266e3f044a...

Powered by Google App Engine
This is Rietveld 408576698