Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2885453002: [turbolizer] Match instruction offsets as a hexadecimal numbers (Closed)

Created:
3 years, 7 months ago by Pierre Langlois
Modified:
3 years, 7 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Match instruction offsets as a hexadecimal numbers The output of disassemblers was changed to display instruction offsets as hexadecimal numbers instead of a decimal numbers. Reflect this change in turbolizer. BUG= Review-Url: https://codereview.chromium.org/2885453002 Cr-Commit-Position: refs/heads/master@{#45315} Committed: https://chromium.googlesource.com/v8/v8/+/2dc261e1c4f297235181b502d9cd53f02fe50938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/turbolizer/disassembly-view.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Pierre Langlois
3 years, 7 months ago (2017-05-15 16:06:33 UTC) #2
danno
lgtm
3 years, 7 months ago (2017-05-15 16:18:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885453002/1
3 years, 7 months ago (2017-05-15 16:29:51 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 17:43:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2dc261e1c4f297235181b502d9cd53f02fe...

Powered by Google App Engine
This is Rietveld 408576698