Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2885413003: Fix detection of GMS proguard.txt files (Closed)

Created:
3 years, 7 months ago by paulmiller
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix detection of GMS proguard.txt files We were mistakenly checking the existence of the directory containing the file, rather than the actual file. BUG=706943 Review-Url: https://codereview.chromium.org/2885413003 Cr-Commit-Position: refs/heads/master@{#472931} Committed: https://chromium.googlesource.com/chromium/src/+/a0fbb7c0d4e4b52d9170031a8883c60e19f4916c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/play_services/preprocess.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
paulmiller
On 2017/05/17 22:11:15, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:mikecase@chromium.org PTAL. In case ...
3 years, 7 months ago (2017-05-17 22:13:06 UTC) #3
mikecase (-- gone --)
lgtm
3 years, 7 months ago (2017-05-17 23:20:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885413003/1
3 years, 7 months ago (2017-05-17 23:23:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429930)
3 years, 7 months ago (2017-05-18 02:43:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885413003/1
3 years, 7 months ago (2017-05-18 18:44:44 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 21:06:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0fbb7c0d4e4b52d9170031a8883...

Powered by Google App Engine
This is Rietveld 408576698