Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2885363006:
MD Settings: Remove usage of paper-material. (Closed)
|
Created:
3 years, 7 months ago by dpapad Modified:
3 years, 7 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, Dan Beam, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Remove usage of paper-material.
Instead replace it with an appropriately styled div.
As a fortunate side-effect, this CL makes the box-shadow effect work
in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13
BUG=598516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2885363006
Cr-Commit-Position: refs/heads/master@{#473781}
Committed: https://chromium.googlesource.com/chromium/src/+/43417886667f8c68d74056371a61845cdaddd4a9
Patch Set 1 #
Total comments: 2
Messages
Total messages: 22 (14 generated)
Description was changed from ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriatly styled div. BUG=598516 ========== to ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriatly styled div. BUG=598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriatly styled div. BUG=598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriatly styled div. As a fortunate side-effect, this CL makes the box-shadow effect work in Vulcanized mode, because it sidesteps https://github.com/Polymer/polymer-css-build/blob/master/index.js#L320. BUG=598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dpapad@chromium.org changed reviewers: + stevenjb@chromium.org
There should be no visual change, see after screenshot at http://imgur.com/a/MWZXQ. https://codereview.chromium.org/2885363006/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/device_page/display_layout.html (right): https://codereview.chromium.org/2885363006/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/device_page/display_layout.html:62: <div id="_mirror_[[item.id]]" class="display mirror" It is unclear to me whether this should also have the box-shadow. It did not have it before my CL, so I am leaving it as-is, but it seems odd that it does not.
Description was changed from ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriatly styled div. As a fortunate side-effect, this CL makes the box-shadow effect work in Vulcanized mode, because it sidesteps https://github.com/Polymer/polymer-css-build/blob/master/index.js#L320. BUG=598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriately styled div. As a fortunate side-effect, this CL makes the box-shadow effect work in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13 BUG=598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
lgtm
On 2017/05/20 at 03:17:05, dbeam wrote: > lgtm @stevenjb: Friendly ping.
lgtm https://codereview.chromium.org/2885363006/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/device_page/display_layout.html (right): https://codereview.chromium.org/2885363006/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/device_page/display_layout.html:62: <div id="_mirror_[[item.id]]" class="display mirror" On 2017/05/20 00:38:33, dpapad wrote: > It is unclear to me whether this should also have the box-shadow. It did not > have it before my CL, so I am leaving it as-is, but it seems odd that it does > not. There were some styling changes done here that I was not involved in. I will have Alan go over them.
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495500611430780, "parent_rev":
"5918d5fbdda9a61e2b83735975fcd7ebbf4d4645", "commit_rev":
"43417886667f8c68d74056371a61845cdaddd4a9"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriately styled div. As a fortunate side-effect, this CL makes the box-shadow effect work in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13 BUG=598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove usage of paper-material. Instead replace it with an appropriately styled div. As a fortunate side-effect, this CL makes the box-shadow effect work in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13 BUG=598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885363006 Cr-Commit-Position: refs/heads/master@{#473781} Committed: https://chromium.googlesource.com/chromium/src/+/43417886667f8c68d74056371a61... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/43417886667f8c68d74056371a61... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
