MD Bookmarks: Prevent keyboard shortcuts when the toolbar/dialogs are focused

chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Tests for MD Bookmarks which are run as interactive ui tests.
  * Should be used for tests which care about focus.
  */
 
 var ROOT_PATH = '../../../../../';
 
 GEN_INCLUDE(
     [ROOT_PATH + 'chrome/test/data/webui/polymer_interactive_ui_test.js']);
 GEN('#include "base/command_line.h"');
 
 function MaterialBookmarksFocusTest() {}
 
 MaterialBookmarksFocusTest.prototype = {
   __proto__: PolymerInteractiveUITest.prototype,
 
   browsePreload: 'chrome://bookmarks',
 
   commandLineSwitches:
       [{switchName: 'enable-features', switchValue: 'MaterialDesignBookmarks'}],
 
   extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+    'test_command_manager.js',
     'test_store.js',
     'test_util.js',
   ]),
 };
 
 TEST_F('MaterialBookmarksFocusTest', 'All', function() {
   suite('<bookmarks-folder-node>', function() {
     var rootNode;
     var store;
 
@@ skipping 134 matching lines @@
       keydown('2', 'ArrowLeft');
       assertDeepEquals(
           bookmarks.actions.changeFolderOpen('2', true), store.lastAction);
 
       keydown('2', 'ArrowRight');
       assertDeepEquals(
           bookmarks.actions.changeFolderOpen('2', false), store.lastAction);
 
       document.body.style.direction = 'ltr';
     });
+
+    test('keyboard commands are passed to command manager', function() {
+      var commandManager = new TestCommandManager();
+      document.body.appendChild(commandManager);
+      chrome.bookmarkManagerPrivate.removeTrees = function() {}
+
+      store.data.selection.items = new Set(['3', '4']);
+      store.notifyObservers();
+
+      getFolderNode('1').$.container.focus();
+      keydown('1', 'delete');
+
+      commandManager.assertLastCommand(Command.DELETE, ['1']);
+    });
   });
 
   suite('<bookmarks-list>', function() {
     var list;
     var store;
     var items;
     var multiKey = cr.isMac ? 'meta' : 'ctrl';
 
     function keydown(item, key, modifiers) {
       MockInteractions.keyDownOn(item, '', modifiers, key);
@@ skipping 146 matching lines @@
       keydown(focusedItem, 'ArrowDown', ['ctrl', 'shift']);
       focusedItem = items[3];
       assertDeepEquals(
           ['2', '4', '5'], normalizeSet(store.data.selection.items));
 
       keydown(focusedItem, 'ArrowDown', ['ctrl', 'shift']);
       focusedItem = items[3];
       assertDeepEquals(
           ['2', '4', '5', '6'], normalizeSet(store.data.selection.items));
     });
+
+    test('keyboard commands are passed to command manager', function() {
+      var commandManager = new TestCommandManager();
+      document.body.appendChild(commandManager);
+      chrome.bookmarkManagerPrivate.removeTrees = function() {}
+
+      store.data.selection.items = new Set(['2', '3']);
+      store.notifyObservers();
+
+      var focusedItem = items[4];
+      focusedItem.focus();
+
+      keydown(focusedItem, 'Delete');
+      // Commands should take affect on the selection, even if something else is
+      // focused.
+      commandManager.assertLastCommand(Command.DELETE, ['2', '3']);
+    });
+
+    test('iron-list does not steal focus on enter', function() {
+      // Iron-list attempts to focus the whole <bookmarks-item> when pressing
+      // enter on the menu button. This checks that we block this behavior
+      // during keydown on <bookmarks-list>.
+      var commandManager = new TestCommandManager();
+      document.body.appendChild(commandManager);
+
+      var button = items[0].$$('.more-vert-button');
+      button.focus();
+      keydown(button, 'Enter');
+
+      assertEquals(button, items[0].root.activeElement);
+    });
   });
 
   mocha.run();
 });