MD Bookmarks: Prevent keyboard shortcuts when the toolbar/dialogs are focused

chrome/browser/resources/md_bookmarks/command_manager.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Element which shows context menus and handles keyboard
  * shortcuts.
  */
 cr.define('bookmarks', function() {
 
@@ skipping 199 matching lines @@
                 folderId, this.getState().nodes));
           } else {
             this.openUrls_(this.expandUrls_(itemIds), command);
           }
           break;
         default:
           assert(false);
       }
     },
 
+    /**
+     * @param {Event} e
+     * @param {!Set<string>} itemIds
+     * @return {boolean} True if the event was handled, triggering a keyboard
+     *     shortcut.
+     */
+    handleKeyEvent: function(e, itemIds) {
+      for (var commandName in this.shortcuts_) {
+        var shortcut = this.shortcuts_[commandName];
+        if (Polymer.IronA11yKeysBehavior.keyboardEventMatchesKeys(
+                e, shortcut) &&
+            this.canExecute(commandName, itemIds)) {
+          this.handle(commandName, itemIds);
+
+          e.stopPropagation();
+          e.preventDefault();
+          return true;
+        }
+      }
+
+      return false;
+    },
+
     ////////////////////////////////////////////////////////////////////////////
     // Private functions:
 
     /**
      * Minimize the set of |itemIds| by removing any node which has an ancestor
      * node already in the set. This ensures that instead of trying to delete
      * both a node and its descendant, we will only try to delete the topmost
      * node, preventing an error in the bookmarkManagerPrivate.removeTrees API
      * call.
      * @param {!Set<string>} itemIds
@@ skipping 103 matching lines @@
       this.handle(e.target.getAttribute('command'), assert(this.menuIds_));
       this.closeCommandMenu();
     },
 
     /**
      * @param {!Event} e
      * @private
      */
     onKeydown_: function(e) {
       var selection = this.getState().selection.items;
-      // TODO(tsergeant): Prevent keyboard shortcuts when a dialog is open or
-      // text field is focused.
-      for (var commandName in this.shortcuts_) {
-        var shortcut = this.shortcuts_[commandName];
-        if (Polymer.IronA11yKeysBehavior.keyboardEventMatchesKeys(
-                e, shortcut) &&
-            this.canExecute(commandName, selection)) {
-          this.handle(commandName, selection);
-
-          e.stopPropagation();
-          e.preventDefault();
-          return;
-        }
-      }
+      if (e.target == document.body)
+        this.handleKeyEvent(e, selection);
     },
 
     /**
      * Close the menu on mousedown so clicks can propagate to the underlying UI.
      * This allows the user to right click the list while a context menu is
      * showing and get another context menu.
      * @param {Event} e
      * @private
      */
     onMenuMousedown_: function(e) {
@@ skipping 58 matching lines @@
 
   /** @return {!bookmarks.CommandManager} */
   CommandManager.getInstance = function() {
     return assert(CommandManager.instance_);
   };
 
   return {
     CommandManager: CommandManager,
   };
 });