Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2885333003: [engine] make Uncaught Exception steps purple. (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 7 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M recipe_engine/run.py View 1 3 chunks +6 lines, -0 lines 0 comments Download
M recipe_engine/step_runner.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
iannucci
3 years, 7 months ago (2017-05-17 08:43:36 UTC) #1
tandrii(chromium)
lgtm
3 years, 7 months ago (2017-05-17 08:45:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885333003/1
3 years, 7 months ago (2017-05-17 08:45:43 UTC) #7
tandrii(chromium)
lgtm
3 years, 7 months ago (2017-05-17 08:55:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885333003/20001
3 years, 7 months ago (2017-05-17 08:57:03 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 08:59:38 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/3b8a0585e3c7390a7c1c339c6b70d042de8...

Powered by Google App Engine
This is Rietveld 408576698