Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 2885333002: Add internal move setter for storage_only fields in ComputedStyle (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by shend
Modified:
1 week, 1 day ago
Reviewers:
nainar
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add internal move setter for storage_only fields in ComputedStyle This patch adds a protected rvalue reference setter for storage_only fields in ComputedStyle. This will allow handwritten setters to take advantage of move semantics (e.g. Length fields, pointer fields). Diff of generated files: https://gist.github.com/b5c155dcd25ab8a89259e1b33f5ece0b/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2885333002 Cr-Commit-Position: refs/heads/master@{#472736} Committed: https://chromium.googlesource.com/chromium/src/+/2cc0e2bbd1160f43d3400c6cc7c67c5a92a62aff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/fields/storage_only.tmpl View 2 chunks +9 lines, -0 lines 0 comments Download
Trybot results:  chromium_presubmit   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   win_chromium_x64_rel_ng   win_clang   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device   ios-device-xcode-clang   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe   win_chromium_rel_ng   chromium_presubmit   win_chromium_rel_ng   win_chromium_rel_ng   win_chromium_rel_ng   linux_chromium_rel_ng   win_clang   win_chromium_rel_ng   win_chromium_x64_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-device-xcode-clang   linux_chromium_rel_ng   ios-simulator   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   linux_chromium_asan_rel_ng   android_n5x_swarming_rel   android_cronet   cast_shell_android   linux_android_rel_ng   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 17 (13 generated)
shend
Hi Naina, PTAL
1 week, 2 days ago (2017-05-17 05:38:31 UTC) #5
nainar
lgtm
1 week, 2 days ago (2017-05-17 06:17:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885333002/1
1 week, 1 day ago (2017-05-18 08:10:39 UTC) #14
commit-bot: I haz the power
1 week, 1 day ago (2017-05-18 08:14:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cc0e2bbd1160f43d3400c6cc7c6...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06