Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 2885333002: Add internal move setter for storage_only fields in ComputedStyle (Closed)

Created:
8 months, 1 week ago by shend
Modified:
8 months, 1 week ago
Reviewers:
nainar
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add internal move setter for storage_only fields in ComputedStyle This patch adds a protected rvalue reference setter for storage_only fields in ComputedStyle. This will allow handwritten setters to take advantage of move semantics (e.g. Length fields, pointer fields). Diff of generated files: https://gist.github.com/b5c155dcd25ab8a89259e1b33f5ece0b/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2885333002 Cr-Commit-Position: refs/heads/master@{#472736} Committed: https://chromium.googlesource.com/chromium/src/+/2cc0e2bbd1160f43d3400c6cc7c67c5a92a62aff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/fields/storage_only.tmpl View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
shend
Hi Naina, PTAL
8 months, 1 week ago (2017-05-17 05:38:31 UTC) #5
nainar
lgtm
8 months, 1 week ago (2017-05-17 06:17:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885333002/1
8 months, 1 week ago (2017-05-18 08:10:39 UTC) #14
commit-bot: I haz the power
8 months, 1 week ago (2017-05-18 08:14:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cc0e2bbd1160f43d3400c6cc7c6...

Powered by Google App Engine
This is Rietveld 408576698