Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2885323002: Add URL generator / json parser for getting start_page_token of changes. (Closed)

Created:
3 years, 7 months ago by yamaguchi
Modified:
3 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add URL generator and JSON parser for getting start_page_token of changes. Currently we use the "largestChangeId" from About:get for knowing the first changestamp of the Changelist of user's Drive. Team Drive's change feeds have individual change stamps each. Therefore we also need to fetch start page token for each team_drive_id using the method. https://developers.google.com/drive/v2/reference/changes/getStartPageToken BUG=715355 TEST=google_apis_unittests --gtest_filter=DriveAPIParserTest.*:DriveApiRequestsTest.*

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M google_apis/drive/drive_api_parser.h View 1 chunk +38 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_parser.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_parser_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_url_generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_url_generator.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_url_generator_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A google_apis/test/data/drive/changes_start_page_token.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yamaguchi
ptal
3 years, 7 months ago (2017-05-17 05:35:26 UTC) #6
hashimoto
Are you willing to add a new API request class? Could you kindly navigate me ...
3 years, 7 months ago (2017-05-17 05:49:48 UTC) #7
yamaguchi
On 2017/05/17 05:49:48, hashimoto wrote: > Are you willing to add a new API request ...
3 years, 7 months ago (2017-05-17 06:47:26 UTC) #11
hashimoto
Sorry, I still don't understand how this is going to work. - Doesn't the current ...
3 years, 7 months ago (2017-05-17 09:15:45 UTC) #12
hashimoto
On 2017/05/17 09:15:45, hashimoto wrote: > Sorry, I still don't understand how this is going ...
3 years, 7 months ago (2017-05-17 09:16:30 UTC) #13
yamaguchi
3 years, 6 months ago (2017-06-05 02:32:21 UTC) #14
As discussed in the design doc, we'll use largestChangeId in Chagnges::list
response instead of getStartPageToken.
I'll abandon this changelist.

Powered by Google App Engine
This is Rietveld 408576698