Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2885313002: Shelf context menu should spawn at cursor position for mouse events. (Closed)

Created:
3 years, 7 months ago by minch1
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Shelf context menu should spawn at cursor position for mouse events. BUG=722878 Review-Url: https://codereview.chromium.org/2885313002 Cr-Commit-Position: refs/heads/master@{#472504} Committed: https://chromium.googlesource.com/chromium/src/+/3d6beb026bad006fcac55b98bc12cfa4d11c6231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M ash/shelf/shelf_view.cc View 1 chunk +23 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
minch1
Hi, msw@, could you help review? Thanks.
3 years, 7 months ago (2017-05-17 16:47:49 UTC) #7
msw
lgtm
3 years, 7 months ago (2017-05-17 17:32:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885313002/1
3 years, 7 months ago (2017-05-17 17:43:08 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 18:17:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d6beb026bad006fcac55b98bc12...

Powered by Google App Engine
This is Rietveld 408576698