Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2885273002: Add <figure> to DOM distiller style preview template (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add <figure> to DOM distiller style preview template BUG= Review-Url: https://codereview.chromium.org/2885273002 Cr-Commit-Position: refs/heads/master@{#472349} Committed: https://chromium.googlesource.com/chromium/src/+/e1e4fbeee3f1175676ef323ba5061da3284b9f94

Patch Set 1 #

Total comments: 2

Patch Set 2 : indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/dom_distiller/core/html/preview.html View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-16 23:19:39 UTC) #2
mdjones
lgtm % nit https://codereview.chromium.org/2885273002/diff/1/components/dom_distiller/core/html/preview.html File components/dom_distiller/core/html/preview.html (right): https://codereview.chromium.org/2885273002/diff/1/components/dom_distiller/core/html/preview.html#newcode300 components/dom_distiller/core/html/preview.html:300: <img Should the contents here be ...
3 years, 7 months ago (2017-05-16 23:31:08 UTC) #3
wychen
https://codereview.chromium.org/2885273002/diff/1/components/dom_distiller/core/html/preview.html File components/dom_distiller/core/html/preview.html (right): https://codereview.chromium.org/2885273002/diff/1/components/dom_distiller/core/html/preview.html#newcode300 components/dom_distiller/core/html/preview.html:300: <img On 2017/05/16 23:31:07, mdjones wrote: > Should the ...
3 years, 7 months ago (2017-05-17 06:12:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885273002/20001
3 years, 7 months ago (2017-05-17 06:13:13 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 06:26:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1e4fbeee3f1175676ef323ba506...

Powered by Google App Engine
This is Rietveld 408576698