[Android] Introduce state machine in stylus text selection

[Android] Introduce state machine in stylus text selection

Stylus text selection state is handled using 2 variables
draaging_ and dragged_. Since both having similar semantics,
we can merge using a state machine.

BUG=

Review-Url: https://codereview.chromium.org/2885243003
Cr-Commit-Position: refs/heads/master@{#473046}
Committed: https://chromium.googlesource.com/chromium/src/+/b70d3b58f1cceeb6f10922f8cb01156a328f3b61

[AKVT, 2017-05-17 14:50:06]

ajith.v@samsung.com changed reviewers:
+ aelias@chromium.org

[AKVT, 2017-05-17 14:50:07]

PTAL!

[aelias_OOO_until_Jul13, 2017-05-17 20:54:24]

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/stylus_text_selector.cc (right):

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/stylus_text_selector.cc:72: drag_state_ =
Clearer to write this as:

if (drag_state_ == DRAGGING_IN_PROGRESS)
  drag_state_ = WAS_DRAGGED;

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/stylus_text_selector.cc:113:
DCHECK(drag_state_ == NO_DRAG);
This isn't equivalent to the previous behavior, I suggest:

DCHECK_NE(DRAGGING_IN_PROGRESS, drag_state_);

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/stylus_text_selector.h (right):

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/stylus_text_selector.h:55:
DRAGGING_IN_PROGRESS,
How about renaming these as:

NO_DRAG,
DRAGGING_WITH_BUTTON_PRESSED,
DRAGGING_WITH_BUTTON_RELEASED,

[AKVT, 2017-05-18 10:08:49]

Description was changed from

==========
[Android] Introudce state machine in styuls text selection

Stylus text selection state is handled using 2 variables
draaging_ and dragged_. Since both having similar semantics,
we can merge using a state machine.

BUG=
==========

to

==========
[Android] Introudce state machine in styuls text selection

Stylus text selection state is handled using 2 variables
draaging_ and dragged_. Since both having similar semantics,
we can merge using a state machine.

BUG=
==========

[AKVT, 2017-05-18 10:11:52]

Description was changed from

==========
[Android] Introudce state machine in styuls text selection

Stylus text selection state is handled using 2 variables
draaging_ and dragged_. Since both having similar semantics,
we can merge using a state machine.

BUG=
==========

to

==========
[Android] Introduce state machine in stylus text selection

Stylus text selection state is handled using 2 variables
draaging_ and dragged_. Since both having similar semantics,
we can merge using a state machine.

BUG=
==========

[AKVT, 2017-05-18 10:12:19]

PTAL!

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/stylus_text_selector.cc (right):

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/stylus_text_selector.cc:72: drag_state_ =
On 2017/05/17 20:54:23, aelias wrote:
> Clearer to write this as:
> 
> if (drag_state_ == DRAGGING_IN_PROGRESS)
>   drag_state_ = WAS_DRAGGED;

Done.

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/stylus_text_selector.cc:113:
DCHECK(drag_state_ == NO_DRAG);
On 2017/05/17 20:54:23, aelias wrote:
> This isn't equivalent to the previous behavior, I suggest:
> 
> DCHECK_NE(DRAGGING_IN_PROGRESS, drag_state_);

Done.

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/stylus_text_selector.h (right):

https://codereview.chromium.org/2885243003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/stylus_text_selector.h:55:
DRAGGING_IN_PROGRESS,
On 2017/05/17 20:54:24, aelias wrote:
> How about renaming these as:
> 
> NO_DRAG,
> DRAGGING_WITH_BUTTON_PRESSED,
> DRAGGING_WITH_BUTTON_RELEASED,

Done. Now it's more clear for readability.

[aelias_OOO_until_Jul13, 2017-05-18 18:22:00]

lgtm

[AKVT, 2017-05-18 19:37:53]

The CQ bit was checked by ajith.v@samsung.com

[commit-bot: I haz the power, 2017-05-18 19:39:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 22:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:35:41]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aelias_OOO_until_Jul13, 2017-05-18 22:39:19]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:40:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:53:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495147159006560,
"parent_rev": "440ee8acf5fc2995762db08f722aa060b14a5e5d", "commit_rev":
"b70d3b58f1cceeb6f10922f8cb01156a328f3b61"}

[commit-bot: I haz the power, 2017-05-19 02:53:57]

Description was changed from

==========
[Android] Introduce state machine in stylus text selection

Stylus text selection state is handled using 2 variables
draaging_ and dragged_. Since both having similar semantics,
we can merge using a state machine.

BUG=
==========

to

==========
[Android] Introduce state machine in stylus text selection

Stylus text selection state is handled using 2 variables
draaging_ and dragged_. Since both having similar semantics,
we can merge using a state machine.

BUG=

Review-Url: https://codereview.chromium.org/2885243003
Cr-Commit-Position: refs/heads/master@{#473046}
Committed:
https://chromium.googlesource.com/chromium/src/+/b70d3b58f1cceeb6f10922f8cb01...
==========

[commit-bot: I haz the power, 2017-05-19 02:53:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b70d3b58f1cceeb6f10922f8cb01...