[Telemetry] Add StoryExpectations to loading.desktop; disabling uol.com story on lin…

[Telemetry] Add StoryExpectations to loading.desktop; disabling uol.com story on linux

Requires https://codereview.chromium.org/2887983003/ to land first

BUG=723783
Review-Url: https://codereview.chromium.org/2885203003
Cr-Commit-Position: refs/heads/master@{#473419}
Committed: https://chromium.googlesource.com/chromium/src/+/205e7f909600e889fdb19e31669ef4a570b71391

[rnephew (Reviews Here), 2017-05-17 19:12:16]

rnephew@chromium.org changed reviewers:
+ charliea@chromium.org, nednguyen@google.com

[rnephew (Reviews Here), 2017-05-18 22:49:21]

On 2017/05/17 19:12:16, rnephew (Reviews Here) wrote:

The next catapult roll (not the currently running one) should have the CL this
relies on in it. After that I will remove the commit=False and [DO NOT SUBMIT]
entries.

[nednguyen, 2017-05-18 23:05:18]

On 2017/05/18 22:49:21, rnephew (Reviews Here) wrote:
> On 2017/05/17 19:12:16, rnephew (Reviews Here) wrote:
> 
> The next catapult roll (not the currently running one) should have the CL this
> relies on in it. After that I will remove the commit=False and [DO NOT SUBMIT]
> entries.

Not in this CL but how do we make sure that if people make a typo, or change
story's name, CQ will prevent them?

[rnephew (Reviews Here), 2017-05-18 23:25:50]

> Not in this CL but how do we make sure that if people make a typo, or change
> story's name, CQ will prevent them?

I'm still working on finding a good solution for that. Deprecating the old
disabling is blocked on it for now unfortunately. When I come up with a good
solution I'll add it to the design document and ping you to review that portion.

[rnephew (Reviews Here), 2017-05-19 20:03:26]

Description was changed from

==========
[DO NOT SUBMIT][Telemetry] Add StoryExpectations to loading.desktop; disabling
uol.com story on linux

Requires https://codereview.chromium.org/2887983003/ to land first
commit=False

BUG=723783
==========

to

==========
[DO NOT SUBMIT][Telemetry] Add StoryExpectations to loading.desktop; disabling
uol.com story on linux

Requires https://codereview.chromium.org/2887983003/ to land first

BUG=723783
==========

[rnephew (Reviews Here), 2017-05-19 20:37:41]

Description was changed from

==========
[DO NOT SUBMIT][Telemetry] Add StoryExpectations to loading.desktop; disabling
uol.com story on linux

Requires https://codereview.chromium.org/2887983003/ to land first

BUG=723783
==========

to

==========
[Telemetry] Add StoryExpectations to loading.desktop; disabling uol.com story on
linux

Requires https://codereview.chromium.org/2887983003/ to land first

BUG=723783
==========

[nednguyen, 2017-05-19 22:28:56]

lgtm

[rnephew (Reviews Here), 2017-05-20 00:29:33]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2017-05-20 00:30:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 04:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 04:13:55]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rnephew (Reviews Here), 2017-05-20 04:42:52]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2017-05-20 04:43:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 05:28:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495255372006950, "parent_rev":
"037910102420f21a96f535ad4e3549426dcb0f4f", "commit_rev":
"205e7f909600e889fdb19e31669ef4a570b71391"}

[commit-bot: I haz the power, 2017-05-20 05:28:57]

Description was changed from

==========
[Telemetry] Add StoryExpectations to loading.desktop; disabling uol.com story on
linux

Requires https://codereview.chromium.org/2887983003/ to land first

BUG=723783
==========

to

==========
[Telemetry] Add StoryExpectations to loading.desktop; disabling uol.com story on
linux

Requires https://codereview.chromium.org/2887983003/ to land first

BUG=723783

Review-Url: https://codereview.chromium.org/2885203003
Cr-Commit-Position: refs/heads/master@{#473419}
Committed:
https://chromium.googlesource.com/chromium/src/+/205e7f909600e889fdb19e31669e...
==========

[commit-bot: I haz the power, 2017-05-20 05:28:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/205e7f909600e889fdb19e31669e...

[perezju, 2017-05-22 11:38:27]

On 2017/05/20 05:28:58, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/205e7f909600e889fdb19e31669e...

This is throwing in my checkout an exception:

Traceback (most recent call last):
  <module> at
/usr/local/google/code/clankium/src/tools/perf/generate_system_health_csv:13
    import page_sets
  <module> at
/usr/local/google/code/clankium/src/tools/perf/page_sets/__init__.py:18
    base_classes = [story.StorySet, story.expectations.StoryExpectations]
AttributeError: 'module' object has no attribute 'expectations'

(And catapult is synced past the CL this depends on.)

Adding at the top:

from telemetry.story import expectations

causes the exception to go away. Any idea why is that? Is this expected?

[rnephew (Reviews Here), 2017-05-22 14:52:16]

On 2017/05/22 11:38:27, perezju wrote:
> On 2017/05/20 05:28:58, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/205e7f909600e889fdb19e31669e...
> 
> This is throwing in my checkout an exception:
> 
> Traceback (most recent call last):
>   <module> at
> /usr/local/google/code/clankium/src/tools/perf/generate_system_health_csv:13
>     import page_sets
>   <module> at
> /usr/local/google/code/clankium/src/tools/perf/page_sets/__init__.py:18
>     base_classes = [story.StorySet, story.expectations.StoryExpectations]
> AttributeError: 'module' object has no attribute 'expectations'
> 
> (And catapult is synced past the CL this depends on.)
> 
> Adding at the top:
> 
> from telemetry.story import expectations
> 
> causes the exception to go away. Any idea why is that? Is this expected?

Huh, I dont get that locally when running benchmarks locally :/  What command
line are you using? And I assume that it worked when you added that to the top
of the __init__ file?