Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2885183002: DevTools: Make sure non-collapsible flamechart groups are treated as expanded. (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make sure non-collapsible flamechart groups are treated as expanded. NOTRY=true Review-Url: https://codereview.chromium.org/2885183002 Cr-Commit-Position: refs/heads/master@{#472254} Committed: https://chromium.googlesource.com/chromium/src/+/07c2492c1970b0bca13093879d1681932c7976fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
alph
3 years, 7 months ago (2017-05-16 20:12:31 UTC) #2
caseq
lgtm
3 years, 7 months ago (2017-05-16 20:14:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885183002/1
3 years, 7 months ago (2017-05-16 20:15:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/428336)
3 years, 7 months ago (2017-05-16 23:11:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885183002/1
3 years, 7 months ago (2017-05-16 23:22:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885183002/1
3 years, 7 months ago (2017-05-16 23:45:13 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 23:51:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07c2492c1970b0bca13093879d16...

Powered by Google App Engine
This is Rietveld 408576698