Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2885173004: [Telemetry] Rename DisableBenchmark to PermenantlyDisableBenchmark in StoryExpectations (Closed)

Created:
3 years, 7 months ago by rnephew (Reviews Here)
Modified:
3 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : add more documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M telemetry/telemetry/story/expectations.py View 1 3 chunks +12 lines, -7 lines 0 comments Download
M telemetry/telemetry/story/expectations_unittest.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rnephew (Reviews Here)
3 years, 7 months ago (2017-05-17 21:02:47 UTC) #2
nednguyen
https://codereview.chromium.org/2885173004/diff/1/telemetry/telemetry/story/expectations.py File telemetry/telemetry/story/expectations.py (right): https://codereview.chromium.org/2885173004/diff/1/telemetry/telemetry/story/expectations.py#newcode42 telemetry/telemetry/story/expectations.py:42: Add more documentation to clarify the meaning of "Permanently"
3 years, 7 months ago (2017-05-17 21:04:36 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/2885173004/diff/1/telemetry/telemetry/story/expectations.py File telemetry/telemetry/story/expectations.py (right): https://codereview.chromium.org/2885173004/diff/1/telemetry/telemetry/story/expectations.py#newcode42 telemetry/telemetry/story/expectations.py:42: On 2017/05/17 21:04:36, nednguyen wrote: > Add more documentation ...
3 years, 7 months ago (2017-05-17 21:08:32 UTC) #4
nednguyen
lgtm
3 years, 7 months ago (2017-05-17 21:10:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885173004/20001
3 years, 7 months ago (2017-05-17 21:11:27 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 21:53:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698