Make AudioDebugFileWriter create its own file worker thread.

Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

The main change of this CL is in media/audio/audio_debug_file_writer.h, the
rest is mostly plumbing.

TBR=jam@chromium.org
BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2885173002
Cr-Commit-Position: refs/heads/master@{#473690}
Committed: https://chromium.googlesource.com/chromium/src/+/4d7742ed008b3b749a757d52f75133dfd5d7f44c

[Sébastien Marchand, 2017-05-16 19:56:02]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 19:57:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2017-05-16 20:03:11]

sebmarchand@chromium.org changed reviewers:
+ fdoray@chromium.org

[Sébastien Marchand, 2017-05-16 20:03:11]

PTAL.

[commit-bot: I haz the power, 2017-05-16 23:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:20:00]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-05-17 14:58:52]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2017-05-17 14:58:52]

https://codereview.chromium.org/2885173002/diff/1/content/browser/speech/spee...
File content/browser/speech/speech_recognizer_impl.cc (right):

https://codereview.chromium.org/2885173002/diff/1/content/browser/speech/spee...
content/browser/speech/speech_recognizer_impl.cc:639: audio_controller_ =
AudioInputController::Create(
The TaskRunner ends up being used here:
https://cs.chromium.org/chromium/src/media/audio/audio_debug_file_writer.h. We
shouldn't pass TaskRunners through several components. Instead, the component
that uses a TaskRunner should be the one that creates it. 

I think it would be worth it to remove the TaskRunner argument from all function
calls between here and the constructor of AudioDebugFileWriter. Then, we could
add a link to this CL in
https://chromium.googlesource.com/chromium/src/+/781747b0aa041e426b6446bd49c1...
to demonstrate best practices. (You will get points for all the files that you
have touched + 5 extra points for adding a link to the CL in the documentation).

[Sébastien Marchand, 2017-05-17 18:47:50]

Description was changed from

==========
Switch SpeechRecognizerImpl to the TaskScheduler API.

BUG=689520
==========

to

==========
Switch SpeechRecognizerImpl to the TaskScheduler API.

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Sébastien Marchand, 2017-05-17 18:48:27]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:49:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:08:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Sébastien Marchand, 2017-05-17 19:35:44]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 19:37:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:46:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sébastien Marchand, 2017-05-18 14:34:39]

Description was changed from

==========
Switch SpeechRecognizerImpl to the TaskScheduler API.

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Switch SpeechRecognizerImpl to the TaskScheduler API.

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Sébastien Marchand, 2017-05-18 14:38:25]

Description was changed from

==========
Switch SpeechRecognizerImpl to the TaskScheduler API.

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Sébastien Marchand, 2017-05-18 14:41:59]

PTAL.

[gab, 2017-05-18 16:10:10]

W00T, this is awesome :), please do a precursor CL for large comment below (I
think it's a nicer example to leave this one without those changes to highlight
how nice it is to remove layers of task runner plumbing).

You can link to precursor requirement in this CL's description

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.h (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:87:
base::CreateSingleThreadTaskRunnerWithTraits(
In general we don't want to create SingleThreadTaskRunners (except with a TODO
to remove it when another top-level bug is fixed or a real explanation of why).

In this case it's just because AudioFileWriter::Create() takes a
SingleThreadTaskRunner, but looking at it it doesn't need to.

AudioFileWriter::AudioFileWriter() merely takes the task runner to assert it's
running on it, that can easily be turned into a SequencedTaskRunner but even
better than that would be to have it use a SequenceChecker to check that all of
its methods run in sequence (will need to DetachFromSequence in
AudioFileWriter::AudioFileWriter() as it's not constructed on same sequence it's
used -- see sequence_checker.h for details).

SequenceChecker + implicit AssertIOAllowed() calls from using base file methods
guarantees this class is being used in sequence with MayBlock() trait. That's
preferred and cleaner than taking a task_runner just to assume running on it.

Then there's OnThreadDeleter which could easily be made OnSequenceDeleter +
SequenceTaskRunner.

And that's it.

So I'd say, please make those changes ahead of this CL and have this one use
base::CreateSequenceTaskRunnerWithTraits() :)

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer_unittest.cc (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer_unittest.cc:175: void
WaitForRecordingCompletion() { scoped_task_environment_.RunUntilIdle(); }
inline scoped_task_environment_.RunUntilIdle() instead of
WaitForRecordingCompletion() below and remove this method

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_input...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_input...
media/audio/audio_input_controller.cc:191: debug_recording_helper_(params,
task_runner_, base::OnceClosure()),
std::move(task_runner) as well while you're here :)

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_manag...
File media/audio/audio_manager.cc (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_manag...
media/audio/audio_manager.cc:284: scoped_refptr<base::SingleThreadTaskRunner>
file_task_runner,
Remove param

[Sébastien Marchand, 2017-05-18 17:43:06]

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.h (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:87:
base::CreateSingleThreadTaskRunnerWithTraits(
On 2017/05/18 16:10:10, gab wrote:
> In general we don't want to create SingleThreadTaskRunners (except with a TODO
> to remove it when another top-level bug is fixed or a real explanation of
why).
> 
> In this case it's just because AudioFileWriter::Create() takes a
> SingleThreadTaskRunner, but looking at it it doesn't need to.
> 
> AudioFileWriter::AudioFileWriter() merely takes the task runner to assert it's
> running on it, that can easily be turned into a SequencedTaskRunner but even
> better than that would be to have it use a SequenceChecker to check that all
of
> its methods run in sequence (will need to DetachFromSequence in
> AudioFileWriter::AudioFileWriter() as it's not constructed on same sequence
it's
> used -- see sequence_checker.h for details).
> 
> SequenceChecker + implicit AssertIOAllowed() calls from using base file
methods
> guarantees this class is being used in sequence with MayBlock() trait. That's
> preferred and cleaner than taking a task_runner just to assume running on it.
> 
> Then there's OnThreadDeleter which could easily be made OnSequenceDeleter +
> SequenceTaskRunner.
> 
> And that's it.
> 
> So I'd say, please make those changes ahead of this CL and have this one use
> base::CreateSequenceTaskRunnerWithTraits() :)

Thanks for the detailed comment! I'm addressing this in
https://codereview.chromium.org/2891983002/

[Sébastien Marchand, 2017-05-18 18:42:48]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 18:44:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2017-05-18 18:52:20]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 18:52:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2017-05-18 19:10:26]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 19:10:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 19:37:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 19:37:15]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[gab, 2017-05-18 22:17:31]

lgtm, please also do a pass to remove unused includes of
single_thread_task_runner.h and possibly also ref_counted.h (i.e. files where
this would have been the last scoped_refptr)

[Sébastien Marchand, 2017-05-19 16:20:39]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 16:21:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 18:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:52:57]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sébastien Marchand, 2017-05-19 20:01:26]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 20:03:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 20:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:11:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sébastien Marchand, 2017-05-19 20:31:41]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 20:32:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 20:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:44:16]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Sébastien Marchand, 2017-05-19 21:01:44]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 21:03:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2017-05-19 21:16:04]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 21:17:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:00:26]

Dry run: This issue passed the CQ dry run.

[Sébastien Marchand, 2017-05-19 23:48:59]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:49:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2017-05-20 00:05:09]

Description was changed from

==========
Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

The main change of this CL is in media/audio/audio_debug_file_writer.h, the
rest is mostly plumbing.

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Sébastien Marchand, 2017-05-20 00:07:16]

sebmarchand@chromium.org changed reviewers:
+ henrika@chromium.org, tommi@chromium.org

[Sébastien Marchand, 2017-05-20 00:28:22]

+some WebRTC folks for owner approval, PTAL.

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer_unittest.cc (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer_unittest.cc:175: void
WaitForRecordingCompletion() { scoped_task_environment_.RunUntilIdle(); }
On 2017/05/18 16:10:10, gab wrote:
> inline scoped_task_environment_.RunUntilIdle() instead of
> WaitForRecordingCompletion() below and remove this method

Done.

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_input...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_input...
media/audio/audio_input_controller.cc:191: debug_recording_helper_(params,
task_runner_, base::OnceClosure()),
On 2017/05/18 16:10:10, gab wrote:
> std::move(task_runner) as well while you're here :)

Done.

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_manag...
File media/audio/audio_manager.cc (right):

https://codereview.chromium.org/2885173002/diff/40001/media/audio/audio_manag...
media/audio/audio_manager.cc:284: scoped_refptr<base::SingleThreadTaskRunner>
file_task_runner,
On 2017/05/18 16:10:10, gab wrote:
> Remove param

Done.

[commit-bot: I haz the power, 2017-05-20 03:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 03:13:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[henrika (OOO until Aug 14), 2017-05-22 08:00:04]

I am only owner in media/audio/windows but lgtm from my side to prevent delays.

[tommi (sloooow) - chröme, 2017-05-22 08:11:56]

lgtm

[Sébastien Marchand, 2017-05-22 13:43:52]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2017-05-22 13:43:53]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2885173002/#ps180001
(title: "Remove useless include")

[commit-bot: I haz the power, 2017-05-22 13:44:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 13:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 13:53:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sébastien Marchand, 2017-05-22 14:16:28]

sebmarchand@chromium.org changed reviewers:
+ jam@chromium.org

[Sébastien Marchand, 2017-05-22 14:16:29]

+jam@ for /content/browser approval.

[Sébastien Marchand, 2017-05-22 19:39:49]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:40:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:44:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:44:52]

Dry run: This issue passed the CQ dry run.

[Sébastien Marchand, 2017-05-22 20:56:40]

Description was changed from

==========
Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

The main change of this CL is in media/audio/audio_debug_file_writer.h, the
rest is mostly plumbing.

BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

The main change of this CL is in media/audio/audio_debug_file_writer.h, the
rest is mostly plumbing.

TBR=jam@chromium.org
BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Sébastien Marchand, 2017-05-22 20:56:54]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:57:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 21:03:56]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1495486614164040,
"parent_rev": "de8adfb9a185c752df2f7e464e77620badd313e0", "commit_rev":
"4d7742ed008b3b749a757d52f75133dfd5d7f44c"}

[commit-bot: I haz the power, 2017-05-22 21:04:09]

Description was changed from

==========
Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

The main change of this CL is in media/audio/audio_debug_file_writer.h, the
rest is mostly plumbing.

TBR=jam@chromium.org
BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make AudioDebugFileWriter create its own file worker thread.

Remove the task_runner from AudioDebugFileWriter's constructor and make it
use the new TaskScheduler API.

TaskRunners shouldn't be passed through several components. Instead, the
component that uses a TaskRunner should be the one that creates it. 

The main change of this CL is in media/audio/audio_debug_file_writer.h, the
rest is mostly plumbing.

TBR=jam@chromium.org
BUG=689520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2885173002
Cr-Commit-Position: refs/heads/master@{#473690}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d7742ed008b3b749a757d52f751...
==========

[commit-bot: I haz the power, 2017-05-22 21:04:10]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/4d7742ed008b3b749a757d52f751...