Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2885163004: [ObjC ARC] Converts ios/chrome/browser:browser_internal to ARC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by liaoyuke
Modified:
2 months, 3 weeks ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser:browser_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2885163004 Cr-Commit-Position: refs/heads/master@{#473563} Committed: https://chromium.googlesource.com/chromium/src/+/73a88dcd92b92ad194b1a61f371a26ae81fae65b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/callback_counter.mm View 1 chunk +4 lines, -0 lines 0 comments Download
Trybot results:  win_clang   win_chromium_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   ios-device-xcode-clang   ios-simulator   ios-device   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe   win_chromium_x64_rel_ng   win_clang   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   linux_chromium_tsan_rel_ng   ios-device-xcode-clang   ios-device   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   chromium_presubmit   linux_android_rel_ng   cast_shell_android   chromeos_daisy_chromium_compile_only_ng   android_cronet   android_n5x_swarming_rel   android_compile_dbg   android_arm64_dbg_recipe   android_clang_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
liaoyuke
3 months ago (2017-05-18 18:00:51 UTC) #6
sdefresne
lgtm
2 months, 3 weeks ago (2017-05-22 11:56:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885163004/1
2 months, 3 weeks ago (2017-05-22 11:57:12 UTC) #9
commit-bot: I haz the power
2 months, 3 weeks ago (2017-05-22 13:13:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73a88dcd92b92ad194b1a61f371a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b