Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2885163004: [ObjC ARC] Converts ios/chrome/browser:browser_internal to ARC. (Closed)

Created:
11 months, 1 week ago by liaoyuke
Modified:
11 months, 1 week ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser:browser_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2885163004 Cr-Commit-Position: refs/heads/master@{#473563} Committed: https://chromium.googlesource.com/chromium/src/+/73a88dcd92b92ad194b1a61f371a26ae81fae65b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/callback_counter.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
liaoyuke
11 months, 1 week ago (2017-05-18 18:00:51 UTC) #6
sdefresne
lgtm
11 months, 1 week ago (2017-05-22 11:56:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885163004/1
11 months, 1 week ago (2017-05-22 11:57:12 UTC) #9
commit-bot: I haz the power
11 months, 1 week ago (2017-05-22 13:13:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73a88dcd92b92ad194b1a61f371a...

Powered by Google App Engine
This is Rietveld 408576698