Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2885143010: Fix location line for shared-with-me directory (Closed)

Created:
3 years, 7 months ago by yamaguchi
Modified:
3 years, 7 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix location line for shared-with-me directory It inserted extra "r" directory when the display root full path begins with "/other". This was a regression introduced by 2839863002. https://codereview.chromium.org/2839863002/diff/240001/ui/file_manager/file_manager/foreground/js/ui/location_line.js TEST=manually verified in the Files app. BUG=723972 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885143010 Cr-Commit-Position: refs/heads/master@{#472728} Committed: https://chromium.googlesource.com/chromium/src/+/3948e1ac83818850cda8a68916e90501beb785a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/location_line.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yamaguchi
ptal
3 years, 7 months ago (2017-05-18 07:26:02 UTC) #6
fukino
lgtm
3 years, 7 months ago (2017-05-18 07:28:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885143010/1
3 years, 7 months ago (2017-05-18 07:47:38 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 07:53:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3948e1ac83818850cda8a68916e9...

Powered by Google App Engine
This is Rietveld 408576698