Use the task scheduler in the new Windows USB backend

Use the task scheduler in the new Windows USB backend

This removes the last UsbService*::Create() method taking a
SequencedTaskRunner, allowing us to start cleaning up DeviceClient as
well.

BUG=None

Review-Url: https://codereview.chromium.org/2885143002
Cr-Commit-Position: refs/heads/master@{#472243}
Committed: https://chromium.googlesource.com/chromium/src/+/4eea68788021df0f3aaf0ad7caea8043f9142617

[Reilly Grant (use Gerrit), 2017-05-16 19:44:10]

Description was changed from

==========
Use the task scheduler in the new Windows USB backend

This removes the last UsbService*::Create() method taking a
SequencedTaskRunner, allowing us to start cleaning up DeviceClient as
well.

Bug: None
==========

to

==========
Use the task scheduler in the new Windows USB backend

This removes the last UsbService*::Create() method taking a
SequencedTaskRunner, allowing us to start cleaning up DeviceClient as
well.

BUG=None
==========

[Reilly Grant (use Gerrit), 2017-05-16 19:44:11]

reillyg@chromium.org changed reviewers:
+ mcasas@chromium.org

[Reilly Grant (use Gerrit), 2017-05-16 19:45:27]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 19:46:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-05-16 19:49:22]

PTAL

[mcasas, 2017-05-16 21:24:25]

lgtm

https://codereview.chromium.org/2885143002/diff/1/device/hid/hid_connection_u...
File device/hid/hid_connection_unittest.cc (right):

https://codereview.chromium.org/2885143002/diff/1/device/hid/hid_connection_u...
device/hid/hid_connection_unittest.cc:175: base::test::ScopedTaskEnvironment
scoped_task_environment_;
Probably can be made const, and |io_thread_| too.

https://codereview.chromium.org/2885143002/diff/1/device/u2f/u2f_hid_device_u...
File device/u2f/u2f_hid_device_unittest.cc (right):

https://codereview.chromium.org/2885143002/diff/1/device/u2f/u2f_hid_device_u...
device/u2f/u2f_hid_device_unittest.cc:171: base::test::ScopedTaskEnvironment
scoped_task_environment_;
nit: probably const.

https://codereview.chromium.org/2885143002/diff/1/device/usb/usb_service_unit...
File device/usb/usb_service_unittest.cc (right):

https://codereview.chromium.org/2885143002/diff/1/device/usb/usb_service_unit...
device/usb/usb_service_unittest.cc:35: base::TestIOThread io_thread_;
nit: probably const, and |scoped_task_environment_| as well.

[Reilly Grant (use Gerrit), 2017-05-16 21:59:08]

https://codereview.chromium.org/2885143002/diff/1/device/hid/hid_connection_u...
File device/hid/hid_connection_unittest.cc (right):

https://codereview.chromium.org/2885143002/diff/1/device/hid/hid_connection_u...
device/hid/hid_connection_unittest.cc:175: base::test::ScopedTaskEnvironment
scoped_task_environment_;
On 2017/05/16 21:24:24, mcasas wrote:
> Probably can be made const, and |io_thread_| too.

These fields can be made const because we don't call any of their non-const
member functions but the idea of a const task environment or thread feels odd to
me.

[Reilly Grant (use Gerrit), 2017-05-16 21:59:24]

The CQ bit was unchecked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-05-16 21:59:28]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:00:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494971968660280, "parent_rev":
"8cc767cb0d1c65af6d5a36858c9633c929b7e4cd", "commit_rev":
"4eea68788021df0f3aaf0ad7caea8043f9142617"}

[commit-bot: I haz the power, 2017-05-16 23:18:10]

Description was changed from

==========
Use the task scheduler in the new Windows USB backend

This removes the last UsbService*::Create() method taking a
SequencedTaskRunner, allowing us to start cleaning up DeviceClient as
well.

BUG=None
==========

to

==========
Use the task scheduler in the new Windows USB backend

This removes the last UsbService*::Create() method taking a
SequencedTaskRunner, allowing us to start cleaning up DeviceClient as
well.

BUG=None

Review-Url: https://codereview.chromium.org/2885143002
Cr-Commit-Position: refs/heads/master@{#472243}
Committed:
https://chromium.googlesource.com/chromium/src/+/4eea68788021df0f3aaf0ad7caea...
==========

[commit-bot: I haz the power, 2017-05-16 23:18:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4eea68788021df0f3aaf0ad7caea...

[mcasas, 2017-05-16 23:19:48]

https://codereview.chromium.org/2885143002/diff/1/device/hid/hid_connection_u...
File device/hid/hid_connection_unittest.cc (right):

https://codereview.chromium.org/2885143002/diff/1/device/hid/hid_connection_u...
device/hid/hid_connection_unittest.cc:175: base::test::ScopedTaskEnvironment
scoped_task_environment_;
On 2017/05/16 21:59:08, Reilly Grant wrote:
> On 2017/05/16 21:24:24, mcasas wrote:
> > Probably can be made const, and |io_thread_| too.
> 
> These fields can be made const because we don't call any of their non-const
> member functions but the idea of a const task environment or thread feels odd
to
> me.

I like const fields because it tells me that they'll
be constructed or passed on constructor, and then 
essentially never mutated.  Eases the reader's load.