[CRD iOS] Use an Action Sheet and target the FAB.

Use an Action Sheet and target the FAB.

Talked with Jon and there are no mocks for what the menu should look like, so I did enough to make the menu work on iPad but that is it. Going to wait until we gets some screens for design to finish the menu but for now this will allow us to continue work.

R=Yuweih@chromium.org

Review-Url: https://codereview.chromium.org/2885103002
Cr-Commit-Position: refs/heads/master@{#473683}
Committed: https://chromium.googlesource.com/chromium/src/+/54bafaab23c53c4e2261acd661a837530685dfef

[nicholss, 2017-05-16 18:37:50]

Description was changed from

==========
Use an Action Sheet and target the FAB.

R=Yuweih@chromium.org
==========

to

==========
Use an Action Sheet and target the FAB.

R=Yuweih@chromium.org
==========

[nicholss, 2017-05-16 18:49:17]

Description was changed from

==========
Use an Action Sheet and target the FAB.

R=Yuweih@chromium.org
==========

to

==========
Use an Action Sheet and target the FAB.

Talked with Jon and there are no mocks for what the menu should look like, so I
did enough to make the menu work on iPad but that is it. Going to wait until we
gets some screens for design to finish the menu but for now this will allow us
to continue work.

R=Yuweih@chromium.org
==========

[nicholss, 2017-05-16 18:49:36]

PTAL, thanks!

[Yuwei, 2017-05-16 20:49:10]

LGTM with nits

https://codereview.chromium.org/2885103002/diff/20001/remoting/ios/app/host_v...
File remoting/ios/app/host_view_controller.mm (right):

https://codereview.chromium.org/2885103002/diff/20001/remoting/ios/app/host_v...
remoting/ios/app/host_view_controller.mm:233:
CGRectMake(self.view.bounds.size.width - kFabInset -
It could be easier to understand if you just do:

CGRectMake(_floatingButton.frame.origin.top,
           _floatingButton.frame.origin.left + width / 2.f,
           1.f, 1.f);

[nicholss, 2017-05-16 21:00:43]

Thanks for the review.

https://codereview.chromium.org/2885103002/diff/20001/remoting/ios/app/host_v...
File remoting/ios/app/host_view_controller.mm (right):

https://codereview.chromium.org/2885103002/diff/20001/remoting/ios/app/host_v...
remoting/ios/app/host_view_controller.mm:233:
CGRectMake(self.view.bounds.size.width - kFabInset -
On 2017/05/16 20:49:10, Yuwei wrote:
> It could be easier to understand if you just do:
> 
> CGRectMake(_floatingButton.frame.origin.top,
>            _floatingButton.frame.origin.left + width / 2.f,
>            1.f, 1.f);

One better:

  alert.popoverPresentationController.sourceRect =
      CGRectMake(_floatingButton.center.x, _floatingButton.frame.origin.y,
                 1.0, 1.0);

Updated.

[Yuwei, 2017-05-16 21:18:54]

https://codereview.chromium.org/2885103002/diff/20001/remoting/ios/app/host_v...
File remoting/ios/app/host_view_controller.mm (right):

https://codereview.chromium.org/2885103002/diff/20001/remoting/ios/app/host_v...
remoting/ios/app/host_view_controller.mm:233:
CGRectMake(self.view.bounds.size.width - kFabInset -
On 2017/05/16 21:00:43, nicholss wrote:
> On 2017/05/16 20:49:10, Yuwei wrote:
> > It could be easier to understand if you just do:
> > 
> > CGRectMake(_floatingButton.frame.origin.top,
> >            _floatingButton.frame.origin.left + width / 2.f,
> >            1.f, 1.f);
> 
> One better:
> 
>   alert.popoverPresentationController.sourceRect =
>       CGRectMake(_floatingButton.center.x, _floatingButton.frame.origin.y,
>                  1.0, 1.0);
> 
> Updated.

Yep. That's much better :)

[nicholss, 2017-05-22 20:32:36]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2017-05-22 20:32:37]

The patchset sent to the CQ was uploaded after l-g-t-m from yuweih@chromium.org
Link to the patchset: https://codereview.chromium.org/2885103002/#ps40001
(title: "Less math to find the top center of the FAB.")

[commit-bot: I haz the power, 2017-05-22 20:33:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:46:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495485156614290,
"parent_rev": "a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c", "commit_rev":
"54bafaab23c53c4e2261acd661a837530685dfef"}

[commit-bot: I haz the power, 2017-05-22 20:46:33]

Description was changed from

==========
Use an Action Sheet and target the FAB.

Talked with Jon and there are no mocks for what the menu should look like, so I
did enough to make the menu work on iPad but that is it. Going to wait until we
gets some screens for design to finish the menu but for now this will allow us
to continue work.

R=Yuweih@chromium.org
==========

to

==========
Use an Action Sheet and target the FAB.

Talked with Jon and there are no mocks for what the menu should look like, so I
did enough to make the menu work on iPad but that is it. Going to wait until we
gets some screens for design to finish the menu but for now this will allow us
to continue work.

R=Yuweih@chromium.org

Review-Url: https://codereview.chromium.org/2885103002
Cr-Commit-Position: refs/heads/master@{#473683}
Committed:
https://chromium.googlesource.com/chromium/src/+/54bafaab23c53c4e2261acd661a8...
==========

[commit-bot: I haz the power, 2017-05-22 20:46:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/54bafaab23c53c4e2261acd661a8...