Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2885093002: Enable multidex for debug builds of system_webview_apk_tmpl-based apks. (Closed)

Created:
3 years, 7 months ago by jbudorick
Modified:
3 years, 7 months ago
Reviewers:
boliu, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable multidex for debug builds of system_webview_apk_tmpl-based apks. Relocated from https://chromium-review.googlesource.com/c/506720/ due to gerrit CQ issues. BUG=722781 TBR=boliu@chromium.org,torne@chromium.org Review-Url: https://codereview.chromium.org/2885093002 Cr-Commit-Position: refs/heads/master@{#472217} Committed: https://chromium.googlesource.com/chromium/src/+/f5ac1cf6941b6b5bbdfaabf6287e5a826c4b602d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M android_webview/system_webview_apk_tmpl.gni View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
jbudorick
TBR: identical to already-reviewed gerrit CL.
3 years, 7 months ago (2017-05-16 18:08:16 UTC) #1
boliu
lgtm
3 years, 7 months ago (2017-05-16 18:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885093002/1
3 years, 7 months ago (2017-05-16 20:45:13 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 21:09:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5ac1cf6941b6b5bbdfaabf6287e...

Powered by Google App Engine
This is Rietveld 408576698