Give v8 a chance to handle signals

Give v8 a chance to handle signals

V8 is starting to use guard regions and a signal handler to do out of bounds
checks for WebAssembly. This means out of bounds accesses will trigger a
segmentation fault, but V8 is able to recover from these and throw a Javascript
exception instead. In order to do this, V8 needs to cooperate with any existing
signal handlers.

This CL modifies Chromium's signal handlers to call V8's TryHandleSignal
function before taking any other actions so that V8 is able to recover from the
faults it expects.

BUG=chromium:722585, v8:5277
Review-Url: https://codereview.chromium.org/2885053005
Cr-Commit-Position: refs/heads/master@{#487549}
Committed: https://chromium.googlesource.com/chromium/src/+/978f6fdb8825bfaed72ce01b8846059587788cdf

[Eric Holk, 2017-06-23 03:49:15]

eholk@chromium.org changed reviewers:
+ mark@chromium.org

[Eric Holk, 2017-06-23 03:49:31]

The CQ bit was checked by eholk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 03:49:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 03:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 03:53:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Holk, 2017-06-23 04:01:28]

The CQ bit was checked by eholk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 04:01:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 04:05:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 04:05:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Holk, 2017-06-23 04:07:42]

The CQ bit was checked by eholk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 04:07:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 05:22:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 05:22:19]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2017-06-23 16:36:08]

LGTM

[eholk (please use chromium), 2017-07-17 16:17:51]

eholk@google.com changed reviewers:
+ eholk@google.com, jochen@chromium.org

[eholk (please use chromium), 2017-07-17 16:17:52]

Jochen, would you be willing to look at the chrome/ parts of this CL?

Thanks!
Eric

[jochen (gone - plz use gerrit), 2017-07-18 08:07:08]

lgtm

[eholk (please use chromium), 2017-07-18 17:25:04]

The CQ bit was checked by eholk@google.com

[eholk (please use chromium), 2017-07-18 17:25:04]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2885053005/#ps200001
(title: "Rebasing")

[eholk (please use chromium), 2017-07-18 17:25:10]

On 2017/07/18 08:07:08, jochen (gone - plz use gerrit) wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2017-07-18 17:25:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-18 19:12:18]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1500398704093930,
"parent_rev": "9ecc7ea64164c15ef9d6e977903a40c270ef8441", "commit_rev":
"978f6fdb8825bfaed72ce01b8846059587788cdf"}

[commit-bot: I haz the power, 2017-07-18 19:12:37]

Description was changed from

==========
Give v8 a chance to handle signals

V8 is starting to use guard regions and a signal handler to do out of bounds
checks for WebAssembly. This means out of bounds accesses will trigger a
segmentation fault, but V8 is able to recover from these and throw a Javascript
exception instead. In order to do this, V8 needs to cooperate with any existing
signal handlers.

This CL modifies Chromium's signal handlers to call V8's TryHandleSignal
function before taking any other actions so that V8 is able to recover from the
faults it expects.

BUG= chromium:722585, v8:5277
==========

to

==========
Give v8 a chance to handle signals

V8 is starting to use guard regions and a signal handler to do out of bounds
checks for WebAssembly. This means out of bounds accesses will trigger a
segmentation fault, but V8 is able to recover from these and throw a Javascript
exception instead. In order to do this, V8 needs to cooperate with any existing
signal handlers.

This CL modifies Chromium's signal handlers to call V8's TryHandleSignal
function before taking any other actions so that V8 is able to recover from the
faults it expects.

BUG= chromium:722585, v8:5277

Review-Url: https://codereview.chromium.org/2885053005
Cr-Commit-Position: refs/heads/master@{#487549}
Committed:
https://chromium.googlesource.com/chromium/src/+/978f6fdb8825bfaed72ce01b8846...
==========

[commit-bot: I haz the power, 2017-07-18 19:12:38]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/978f6fdb8825bfaed72ce01b8846...