|
|
Created:
3 years, 7 months ago by shend Modified:
3 years, 7 months ago Reviewers:
meade_UTC10 CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove StyleRareInheritedData.cpp to be inline in StyleRareInheritedData.h
This patch removes StyleRareInheritedData.cpp, and moves all its contents to be
inline in StyleRareInheritedData.h
This is prework for generating StyleRareInheritedData.
BUG=628043
Review-Url: https://codereview.chromium.org/2885033006
Cr-Commit-Position: refs/heads/master@{#473854}
Committed: https://chromium.googlesource.com/chromium/src/+/eca71d2d20a47358b8e0b7931b70d796264acbe1
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #
Dependent Patchsets: Messages
Total messages: 36 (32 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shend@chromium.org changed reviewers: + meade@chromium.org
Hi Eddy, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495522201947800, "parent_rev": "f22c112e0e74aa001c68b93b95824a8a5b554921", "commit_rev": "eca71d2d20a47358b8e0b7931b70d796264acbe1"}
Message was sent while issue was closed.
Description was changed from ========== Move StyleRareInheritedData.cpp to be inline in StyleRareInheritedData.h This patch removes StyleRareInheritedData.cpp, and moves all its contents to be inline in StyleRareInheritedData.h This is prework for generating StyleRareInheritedData. BUG=628043 ========== to ========== Move StyleRareInheritedData.cpp to be inline in StyleRareInheritedData.h This patch removes StyleRareInheritedData.cpp, and moves all its contents to be inline in StyleRareInheritedData.h This is prework for generating StyleRareInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2885033006 Cr-Commit-Position: refs/heads/master@{#473854} Committed: https://chromium.googlesource.com/chromium/src/+/eca71d2d20a47358b8e0b7931b70... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/eca71d2d20a47358b8e0b7931b70... |