Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2885033006: Move StyleRareInheritedData.cpp to be inline in StyleRareInheritedData.h (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StyleRareInheritedData.cpp to be inline in StyleRareInheritedData.h This patch removes StyleRareInheritedData.cpp, and moves all its contents to be inline in StyleRareInheritedData.h This is prework for generating StyleRareInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2885033006 Cr-Commit-Position: refs/heads/master@{#473854} Committed: https://chromium.googlesource.com/chromium/src/+/eca71d2d20a47358b8e0b7931b70d796264acbe1

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -196 lines) Patch
M third_party/WebKit/Source/core/style/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 1 2 3 4 4 chunks +130 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 2 3 1 chunk +0 lines, -188 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (32 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-18 07:40:51 UTC) #8
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-23 04:50:29 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885033006/80001
3 years, 7 months ago (2017-05-23 06:50:18 UTC) #33
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 10:52:18 UTC) #36
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/eca71d2d20a47358b8e0b7931b70...

Powered by Google App Engine
This is Rietveld 408576698