Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 2885023002: Add NTPCondensedLayout to test config. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Michael van Ouwerkerk
Modified:
2 months, 3 weeks ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NTPCondensedLayout to test config. BUG=688291 Review-Url: https://codereview.chromium.org/2885023002 Cr-Commit-Position: refs/heads/master@{#473225} Committed: https://chromium.googlesource.com/chromium/src/+/de26ab98dcd8747564fd3e078db2862a53cb7246

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Disable condensed layout in tests that require a logo. #

Patch Set 4 : Add NTPCondensedLayout to test config. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 22 (16 generated)
Michael van Ouwerkerk
Bernhard: please take a look from feature perspective Alexei: please take a look from a ...
3 months ago (2017-05-16 14:48:45 UTC) #2
Bernhard Bauer
lgtm
3 months ago (2017-05-16 15:30:30 UTC) #6
Alexei Svitkine (slow)
lgtm
3 months ago (2017-05-16 16:52:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885023002/40001
2 months, 4 weeks ago (2017-05-19 15:26:07 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/de26ab98dcd8747564fd3e078db2862a53cb7246
2 months, 4 weeks ago (2017-05-19 17:22:00 UTC) #21
mikecase (-- gone --)
2 months, 4 weeks ago (2017-05-19 23:35:11 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2898533003/ by mikecase@chromium.org.

The reason for reverting is: crbug/724698

May be causing tests failures of NewTabPageTest. Small cl, so just going to
revert..
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b