Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2884953004: [Sync] Set signed in account before AndroidSyncSettings to match test expectations (Closed)

Created:
3 years, 7 months ago by pavely
Modified:
3 years, 7 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Set signed in account before AndroidSyncSettings to match test expectations Test expectation is that there is no signed in account at the beginning, and by the end of setUp test expects mAccount to appear signed in from AndroidSyncSettings perspective. It is done by calling updateAccount(mAccount) from setUp(). The issue happens when there is another signed in account according to ChromeSigninController.getSignedInAccountName, potentially left from some other test execution. The fix is to reset signed in account with ChromeSigninController.setSignedInAccountName before AndroidSyncSettings initialization. R=skym@chromium.org BUG=717960 Review-Url: https://codereview.chromium.org/2884953004 Cr-Commit-Position: refs/heads/master@{#472232} Committed: https://chromium.googlesource.com/chromium/src/+/7b27ecffa77d8119aa736ecbcb8402256823f956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java View 4 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
pavely
3 years, 7 months ago (2017-05-16 20:59:21 UTC) #2
pavely
3 years, 7 months ago (2017-05-16 20:59:22 UTC) #3
skym
lgtm
3 years, 7 months ago (2017-05-16 21:37:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884953004/1
3 years, 7 months ago (2017-05-16 21:52:15 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 22:44:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b27ecffa77d8119aa736ecbcb84...

Powered by Google App Engine
This is Rietveld 408576698