Fix Mouse Event Tracing (requires making some events blocking.)

Input Latency traced correctly for mouse events.

Previously, in the case where no swap was produced, we didn't
terminate mouse event async slices. Now we do.

This requires making some of the events blocking, as we need to know whether or not renderering was scheduled at the time we process the event ack. If the event is non-blocking, we receive a synthetic ACK immediately, and don't know whether or not rendering will be scheduled.

BUG=722807
Review-Url: https://codereview.chromium.org/2884953002
Cr-Commit-Position: refs/heads/master@{#473334}
Committed: https://chromium.googlesource.com/chromium/src/+/4b3f1a993bb370e07a7679d119fc511cfb5cbb51

[tdresser, 2017-05-16 12:24:50]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 12:25:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdresser, 2017-05-16 12:27:40]

tdresser@chromium.org changed reviewers:
+ oysteine@chromium.org

[tdresser, 2017-05-16 12:27:41]

Oysteine, can you take a look at the test, and let me know if there's a better
way of doing this?

Long term, I'd like to abstract away the trace related callback logic, and just
provide a synchronous API, which returns a vector of some moderately object
representing trace events.

Parsing the json like this is kinda painful.

[commit-bot: I haz the power, 2017-05-16 12:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 12:56:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdresser, 2017-05-16 15:44:19]

Description was changed from

==========
Input Latency traced correctly for mouse events.

Previously, in the case where no swap was produced, we didn't
terminate mouse event async slices. Now we do.

BUG=722807
==========

to

==========
Input Latency traced correctly for mouse events.

Previously, in the case where no swap was produced, we didn't
terminate mouse event async slices. Now we do.

This requires making some of the events blocking, as we need to know whether or
not renderering was scheduled at the time we process the event ack. If the event
is non-blocking, we receive a synthetic ACK immediately, and don't know whether
or not rendering will be scheduled.

BUG=722807
==========

[tdresser, 2017-05-16 15:44:40]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 15:45:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdresser, 2017-05-16 16:48:48]

tdresser@chromium.org changed reviewers:
+ dtapuska@chromium.org

[tdresser, 2017-05-16 16:48:49]

+Dave, for input review.

[dtapuska, 2017-05-16 16:57:20]

On 2017/05/16 16:48:49, tdresser wrote:
> +Dave, for input review.

lgtm % Oysteine still needs to review the test.

[commit-bot: I haz the power, 2017-05-16 18:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:05:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[oystein (OOO til 10th of July), 2017-05-17 02:04:21]

On 2017/05/16 at 12:27:41, tdresser wrote:
> Oysteine, can you take a look at the test, and let me know if there's a better
way of doing this?
> 
> Long term, I'd like to abstract away the trace related callback logic, and
just provide a synchronous API, which returns a vector of some moderately object
representing trace events.
> 
> Parsing the json like this is kinda painful.

From what I can tell, even using the existing testing utilities would include so
much boilerplate that you wouldn't be saving much :/. Fully agree we should have
an easier way of doing this; maybe some of the testing helpers from
trace_event_unittest.cc could be extracted and made more general.

[tdresser, 2017-05-17 12:39:57]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2017-05-17 12:40:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdresser, 2017-05-17 14:05:23]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2017-05-17 14:05:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2884953002/#ps40001
(title: "Disable test on Android, as mouse input isn't supported.")

[commit-bot: I haz the power, 2017-05-17 14:05:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 15:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:29:30]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tdresser, 2017-05-18 13:32:02]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2017-05-18 13:32:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 14:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 14:33:23]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tdresser, 2017-05-19 19:11:21]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2017-05-19 19:12:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:38:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495221081559750,
"parent_rev": "38a14eb81c041f7ae7bff36226318bca3d161e79", "commit_rev":
"4b3f1a993bb370e07a7679d119fc511cfb5cbb51"}

[commit-bot: I haz the power, 2017-05-19 21:39:05]

Description was changed from

==========
Input Latency traced correctly for mouse events.

Previously, in the case where no swap was produced, we didn't
terminate mouse event async slices. Now we do.

This requires making some of the events blocking, as we need to know whether or
not renderering was scheduled at the time we process the event ack. If the event
is non-blocking, we receive a synthetic ACK immediately, and don't know whether
or not rendering will be scheduled.

BUG=722807
==========

to

==========
Input Latency traced correctly for mouse events.

Previously, in the case where no swap was produced, we didn't
terminate mouse event async slices. Now we do.

This requires making some of the events blocking, as we need to know whether or
not renderering was scheduled at the time we process the event ack. If the event
is non-blocking, we receive a synthetic ACK immediately, and don't know whether
or not rendering will be scheduled.

BUG=722807

Review-Url: https://codereview.chromium.org/2884953002
Cr-Commit-Position: refs/heads/master@{#473334}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b3f1a993bb370e07a7679d119fc...
==========

[commit-bot: I haz the power, 2017-05-19 21:39:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4b3f1a993bb370e07a7679d119fc...