Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: components/wifi/wifi_service_mac.mm

Issue 2884933002: Remove raw base::DictionaryValue::SetWithoutPathExpansion (Closed)
Patch Set: Fix Compilation Errors Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/wifi/wifi_service_mac.mm
diff --git a/components/wifi/wifi_service_mac.mm b/components/wifi/wifi_service_mac.mm
index 5b43a4af897b64f6cdb92a73f9a9972a9d22a938..feb5ea43bc72520d760675dfea1ae3b49295252b 100644
--- a/components/wifi/wifi_service_mac.mm
+++ b/components/wifi/wifi_service_mac.mm
@@ -225,7 +225,7 @@ void WiFiServiceMac::SetProperties(
existing_properties->MergeDictionary(properties.get());
} else {
network_properties_.SetWithoutPathExpansion(network_guid,
- properties.release());
+ std::move(properties));
}
}
@@ -245,8 +245,7 @@ void WiFiServiceMac::CreateNetwork(
*error = kErrorInvalidData;
return;
}
- network_properties_.SetWithoutPathExpansion(guid,
- properties.release());
+ network_properties_.SetWithoutPathExpansion(guid, std::move(properties));
*network_guid = guid;
}

Powered by Google App Engine
This is Rietveld 408576698