UMA Metrics for the user menu, including vasquette-detection

chrome/browser/profiles/profile_metrics.cc

Index: chrome/browser/profiles/profile_metrics.cc
diff --git a/chrome/browser/profiles/profile_metrics.cc b/chrome/browser/profiles/profile_metrics.cc
index a829be238793e76afa1d163b7239a18873845578..b18fe81b4c855f11b4994eb7d698dde8d64fa14e 100644
--- a/chrome/browser/profiles/profile_metrics.cc
+++ b/chrome/browser/profiles/profile_metrics.cc
@@ -11,6 +11,7 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/signin/signin_header_helper.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "content/public/browser/browser_thread.h"
@@ -295,6 +296,36 @@ void ProfileMetrics::LogProfileUpgradeEnrollment(
                             NUM_PROFILE_ENROLLMENT_METRICS);
 }
 
+void ProfileMetrics::LogProfileDesktopMenu(ProfileDesktopMenu metric,
+    signin::GAIAServiceType gaia_service) {
+  switch (gaia_service) {

[Alexei Svitkine (slow), 2014/05/26 17:59:40]

Nit: Maybe add a warning comment mentioning that each histogram needs to be
logged separately since UMA macros cache the object (to avoid someone
refactoring this in the future).

[Mike Lerman, 2014/05/27 13:24:46]

Done.

+    case signin::GAIA_SERVICE_TYPE_NONE:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.NonGAIA", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_SIGNOUT:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIASignout", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_SIGNOUTOPTIONS_INCOGNITO:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIASignoutIncognito",
+                                metric, NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_ADDSESSION:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIAAddSession", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_REAUTH:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIAReAuth", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_DEFAULT:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIADefault", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+  }
+}
+
 void ProfileMetrics::LogProfileLaunch(Profile* profile) {
   base::FilePath profile_path = profile->GetPath();
   UMA_HISTOGRAM_ENUMERATION("Profile.LaunchBrowser",