UMA Metrics for the user menu, including vasquette-detection

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/signin/signin_header_helper.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/user_metrics.h"
 
 namespace {
 
 const int kMaximumReportedProfileCount = 5;
 const int kMaximumDaysOfDisuse = 4 * 7;  // Should be integral number of weeks.
 
@@ skipping 264 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.AuthResult", metric,
                             NUM_PROFILE_AUTH_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpgradeEnrollment(
     ProfileUpgradeEnrollment metric) {
   UMA_HISTOGRAM_ENUMERATION("Profile.UpgradeEnrollment", metric,
                             NUM_PROFILE_ENROLLMENT_METRICS);
 }
 
+void ProfileMetrics::LogProfileDesktopMenu(ProfileDesktopMenu metric,
+    signin::GAIAServiceType gaia_service) {
+  switch (gaia_service) {

[Alexei Svitkine (slow), 2014/05/26 17:59:40]

Nit: Maybe add a warning comment mentioning that each histogram needs to be
logged separately since UMA macros cache the object (to avoid someone
refactoring this in the future).

[Mike Lerman, 2014/05/27 13:24:46]

Done.

+    case signin::GAIA_SERVICE_TYPE_NONE:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.NonGAIA", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_SIGNOUT:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIASignout", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_SIGNOUTOPTIONS_INCOGNITO:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIASignoutIncognito",
+                                metric, NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_ADDSESSION:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIAAddSession", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_REAUTH:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIAReAuth", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+    case signin::GAIA_SERVICE_TYPE_DEFAULT:
+      UMA_HISTOGRAM_ENUMERATION("Profile.DesktopMenu.GAIADefault", metric,
+                                NUM_PROFILE_DESKTOP_MENU_METRICS);
+      break;
+  }
+}
+
 void ProfileMetrics::LogProfileLaunch(Profile* profile) {
   base::FilePath profile_path = profile->GetPath();
   UMA_HISTOGRAM_ENUMERATION("Profile.LaunchBrowser",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 
   if (profile->IsManaged()) {
     content::RecordAction(
         base::UserMetricsAction("ManagedMode_NewManagedUserWindow"));
   }
 }
 
 void ProfileMetrics::LogProfileSyncSignIn(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }