Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 288493007: DevTools: allow binding remote debugging to port 0. (Closed)

Created:
6 years, 7 months ago by pfeldman
Modified:
6 years, 7 months ago
Reviewers:
tonyg, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

DevTools: allow binding remote debugging to port 0. BUG=372560 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
6 years, 7 months ago (2014-05-13 13:41:00 UTC) #1
Nico
On 2014/05/13 13:41:00, pfeldman wrote: Patch lgtm. Does binding to port 0 require root? Or ...
6 years, 7 months ago (2014-05-13 13:47:18 UTC) #2
pfeldman
On 2014/05/13 13:47:18, Nico (traveling this week) wrote: > On 2014/05/13 13:41:00, pfeldman wrote: > ...
6 years, 7 months ago (2014-05-13 14:03:24 UTC) #3
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 7 months ago (2014-05-13 14:03:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/288493007/1
6 years, 7 months ago (2014-05-13 14:03:38 UTC) #5
tonyg
On 2014/05/13 13:47:18, Nico (traveling this week) wrote: > On 2014/05/13 13:41:00, pfeldman wrote: > ...
6 years, 7 months ago (2014-05-13 14:03:47 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 15:57:48 UTC) #7
Message was sent while issue was closed.
Change committed as 270108

Powered by Google App Engine
This is Rietveld 408576698