chrome/browser/chrome_browser_main.cc - Issue 288493007: DevTools: allow binding remote debugging to port 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 288493007: DevTools: allow binding remote debugging to port 0. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index 66ec527391a77322151e086e3cad5f257148f89b..ef003a38e4461337d67bb129b1de29ec64ab2197 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -457,7 +457,7 @@ void LaunchDevToolsHandlerIfNeeded(const CommandLine& command_line) {

std::string port_str =

command_line.GetSwitchValueASCII(::switches::kRemoteDebuggingPort);

int port;

- if (base::StringToInt(port_str, &port) && port > 0 && port < 65535) {

+ if (base::StringToInt(port_str, &port) && port >= 0 && port < 65535) {

g_browser_process->CreateDevToolsHttpProtocolHandler(

chrome::HOST_DESKTOP_TYPE_NATIVE,

"127.0.0.1",

« no previous file with comments | « no previous file | no next file » | no next file with comments »