Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 288493002: Fix formatting in skia_test_expectations.txt (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
borenet, robertphillips
CC:
chromium-reviews
Visibility:
Public.

Description

Fix formatting in skia_test_expectations.txt Blink try bots are failing due to failure of Tools/Scripts/lint-test-expectations These were broken in previous CL, b/c the lint test weren't run: Suppressions for DirectWrite tests (line thickness) https://codereview.chromium.org/283503003 TBR=borenet, robertphillips BUG=372497 NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M skia/skia_test_expectations.txt View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Fix for lint error.
6 years, 7 months ago (2014-05-13 04:35:33 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-13 04:35:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/288493002/1
6 years, 7 months ago (2014-05-13 04:35:46 UTC) #3
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 7 months ago (2014-05-13 04:46:47 UTC) #4
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-13 04:46:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/288493002/1
6 years, 7 months ago (2014-05-13 04:47:23 UTC) #6
commit-bot: I haz the power
Change committed as 270014
6 years, 7 months ago (2014-05-13 04:48:40 UTC) #7
Nils Barth (inactive)
On 2014/05/13 04:48:40, I haz the power (commit-bot) wrote: > Change committed as 270014 BTW: ...
6 years, 7 months ago (2014-05-13 04:51:01 UTC) #8
borenet
6 years, 7 months ago (2014-05-13 12:18:31 UTC) #9
Message was sent while issue was closed.
On 2014/05/13 04:51:01, Nils Barth wrote:
> On 2014/05/13 04:48:40, I haz the power (commit-bot) wrote:
> > Change committed as 270014
> 
> BTW:
> Bug filed for lack of tests:
> Skia doesn't check Blink tests (specifically lint-test-expectations)
> https://code.google.com/p/chromium/issues/detail?id=372664

LGTM

Powered by Google App Engine
This is Rietveld 408576698