Issue 283503003: Suppressions for DirectWrite tests (line thickness)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283503003: Suppressions for DirectWrite tests (line thickness) (Closed)

Created:
6 years, 7 months ago by borenet

Modified:
6 years, 7 months ago

Reviewers:
robertphillips, reed1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Suppressions for DirectWrite tests (line thickness) BUG=372497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269988

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	skia/skia_test_expectations.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/283503003/1

6 years, 7 months ago (2014-05-12 18:56:21 UTC) #4

Nils Barth (inactive)

6 years, 7 months ago (2014-05-13 04:50:38 UTC) #6

Message was sent while issue was closed.

On 2014/05/13 03:27:56, I haz the power (commit-bot) wrote:
> Change committed as 269988

This revision broke Blink try bots
(not fault of author: lack of test coverage)

This is fixed in:
Fix formatting in skia_test_expectations.txt
https://codereview.chromium.org/288493002/

Bug filed for lack of tests:
Skia doesn't check Blink tests (specifically lint-test-expectations)
https://code.google.com/p/chromium/issues/detail?id=372664

Expand Messages | Collapse Messages