Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2884903002:
Remove redndunt variables in LayoutSelection::SetSelection() (Closed)
|
Created:
3 years, 7 months ago by yoichio Modified:
3 years, 7 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove redundant variables in LayoutSelection::SetSelection()
Use |selection_{start/end}_pos_| instead of old_{start/end}_pos|
and update |selection_{start/end}_pos_| at the end of SetSelection().
TEST=No change in behavior
BUG=708453
Review-Url: https://codereview.chromium.org/2884903002
Cr-Commit-Position: refs/heads/master@{#472365}
Committed: https://chromium.googlesource.com/chromium/src/+/b27dd8b56144f6373f05716a028b907a4fb21af2
Patch Set 1 : update #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from
==========
Remove redandunt variables in LayoutSelection::SetSelection();
BUG=708453
==========
to
==========
Remove redundant variables in LayoutSelection::SetSelection();
Use |selection_{start/end}_pos_| instead of old_{start/end}_pos|
and update |selection_{start/end}_pos_| at the end of SetSelection().
TEST=No change in behavior
BUG=708453
==========
yoichio@chromium.org changed reviewers: + yosin@chromium.org
Description was changed from
==========
Remove redundant variables in LayoutSelection::SetSelection();
Use |selection_{start/end}_pos_| instead of old_{start/end}_pos|
and update |selection_{start/end}_pos_| at the end of SetSelection().
TEST=No change in behavior
BUG=708453
==========
to
==========
Remove redundant variables in LayoutSelection::SetSelection()
Use |selection_{start/end}_pos_| instead of old_{start/end}_pos|
and update |selection_{start/end}_pos_| at the end of SetSelection().
TEST=No change in behavior
BUG=708453
==========
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yoichio@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495002256577500,
"parent_rev": "0e9b44fea13a90aff88c5a0e7e0164fa99e2418a", "commit_rev":
"b27dd8b56144f6373f05716a028b907a4fb21af2"}
Message was sent while issue was closed.
Description was changed from
==========
Remove redundant variables in LayoutSelection::SetSelection()
Use |selection_{start/end}_pos_| instead of old_{start/end}_pos|
and update |selection_{start/end}_pos_| at the end of SetSelection().
TEST=No change in behavior
BUG=708453
==========
to
==========
Remove redundant variables in LayoutSelection::SetSelection()
Use |selection_{start/end}_pos_| instead of old_{start/end}_pos|
and update |selection_{start/end}_pos_| at the end of SetSelection().
TEST=No change in behavior
BUG=708453
Review-Url: https://codereview.chromium.org/2884903002
Cr-Commit-Position: refs/heads/master@{#472365}
Committed:
https://chromium.googlesource.com/chromium/src/+/b27dd8b56144f6373f05716a028b...
==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b27dd8b56144f6373f05716a028b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
