Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2884873002: Post the task of disabling virtual keyboard (Closed)

Created:
3 years, 7 months ago by Azure Wei
Modified:
3 years, 7 months ago
Reviewers:
stevenjb, Shu Chen
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Post the task of disabling virtual keyboard When show emoji/voice/handwriting vk with opt-in IME menu with virtual keyboard disabled, the virtual keyboard will be forced shown once. Thus, after the virtual keyboard hidden, the menu will disable the vk to make sure it won't automatically brown. The menu listens on KeyboardController::OnKeyboardHidden() event to disable the vk, where SIGSEGV will cause. Fix the issue by posting the task of disabling virtual keyboard. BUG=721673 TEST=Verified on local build Review-Url: https://codereview.chromium.org/2884873002 Cr-Commit-Position: refs/heads/master@{#472300} Committed: https://chromium.googlesource.com/chromium/src/+/e876159e6a71b276bd596c115776623faeba9b47

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M ash/system/ime_menu/ime_menu_tray.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Azure Wei
3 years, 7 months ago (2017-05-16 02:23:41 UTC) #3
stevenjb
lgtm
3 years, 7 months ago (2017-05-16 15:56:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884873002/20001
3 years, 7 months ago (2017-05-17 01:10:04 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 03:17:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e876159e6a71b276bd596c115776...

Powered by Google App Engine
This is Rietveld 408576698