Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2378)

Unified Diff: chrome/browser/chromeos/printing/specifics_translation.cc

Issue 2884863002: Add an autoconf field to printer objects. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/printing/specifics_translation.cc
diff --git a/chrome/browser/chromeos/printing/specifics_translation.cc b/chrome/browser/chromeos/printing/specifics_translation.cc
index 6f5cbae08387434ebea3d3826f6d666bcf82a73a..6e6980938a70314a0fc383d3dbf36cd20a61185b 100644
--- a/chrome/browser/chromeos/printing/specifics_translation.cc
+++ b/chrome/browser/chromeos/printing/specifics_translation.cc
@@ -29,6 +29,10 @@ Printer::PpdReference SpecificsToPpd(
ref.effective_make_and_model = specifics.effective_make_and_model();
}
+ if (specifics.has_autoconf()) {
Carlson 2017/05/16 16:15:27 This conditional isn't useful, I think. If you li
skau 2017/05/16 18:48:06 Acknowledged.
+ ref.autoconf = specifics.autoconf();
+ }
+
return ref;
}
@@ -41,6 +45,8 @@ void MergeReferenceToSpecifics(sync_pb::PrinterPPDReference* specifics,
if (!ref.effective_make_and_model.empty()) {
specifics->set_effective_make_and_model(ref.effective_make_and_model);
}
+
+ specifics->set_autoconf(ref.autoconf);
Carlson 2017/05/16 16:15:27 Conversely, this probably *should* be wrapped in a
skau 2017/05/16 18:48:06 I've made autoconf optional in PpdRefernce so that
Carlson 2017/05/22 23:46:07 I don't understand what you mean by this. Do you
skau 2017/05/23 01:00:21 Acknowledged.
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698