Add an autoconf field to printer objects.

chrome/browser/chromeos/printing/specifics_translation.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
@@ skipping 11 matching lines @@
     const sync_pb::PrinterPPDReference& specifics) {
   Printer::PpdReference ref;
   if (specifics.has_user_supplied_ppd_url()) {
     ref.user_supplied_ppd_url = specifics.user_supplied_ppd_url();
   }
 
   if (specifics.has_effective_make_and_model()) {
     ref.effective_make_and_model = specifics.effective_make_and_model();
   }
 
+  if (specifics.has_autoconf()) {

[Carlson, 2017/05/16 16:15:27]

This conditional isn't useful, I think.  If you like it for orthogonality, ok
(though I'd argue that none of the conditionals in this function are useful)

[skau, 2017/05/16 18:48:06]

Acknowledged.

+    ref.autoconf = specifics.autoconf();
+  }
+
   return ref;
 }
 
 void MergeReferenceToSpecifics(sync_pb::PrinterPPDReference* specifics,
                                const Printer::PpdReference& ref) {
   if (!ref.user_supplied_ppd_url.empty()) {
     specifics->set_user_supplied_ppd_url(ref.user_supplied_ppd_url);
   }
 
   if (!ref.effective_make_and_model.empty()) {
     specifics->set_effective_make_and_model(ref.effective_make_and_model);
   }
+
+  specifics->set_autoconf(ref.autoconf);

[Carlson, 2017/05/16 16:15:27]

Conversely, this probably *should* be wrapped in a conditional.  :)

[skau, 2017/05/16 18:48:06]

I've made autoconf optional in PpdRefernce so that'll have some meaning.

[Carlson, 2017/05/22 23:46:07]

I don't understand what you mean by this.  Do you mean you're using the
existence of the field to have implicit semantics?

[skau, 2017/05/23 01:00:21]

Acknowledged.

 }
 
 }  // namespace
 
 std::unique_ptr<Printer> SpecificsToPrinter(
     const sync_pb::PrinterSpecifics& specifics) {
   DCHECK(!specifics.id().empty());
 
   auto printer = base::MakeUnique<Printer>(
       specifics.id(), base::Time::FromJavaTime(specifics.updated_timestamp()));
@@ skipping 41 matching lines @@
 
   if (!printer.uuid().empty())
     specifics->set_uuid(printer.uuid());
 
   MergeReferenceToSpecifics(specifics->mutable_ppd_reference(),
                             printer.ppd_reference());
 }
 
 }  // namespace printing
 }  // namespace chromeos