Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2884833002:
Add vertical-align:top to render test images. (Closed)
|
Created:
3 years, 7 months ago by mikecase (-- gone --) Modified:
3 years, 7 months ago CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd vertical-align:top to render test images.
This fixes the alignment for when the render test images are a
different size than the golden image. The images are compared by
lining up the top-left corner. Setting vertical-align:top makes
it easier to visualize how the diff image was constructed in this
case.
Review-Url: https://codereview.chromium.org/2884833002
Cr-Commit-Position: refs/heads/master@{#472616}
Committed: https://chromium.googlesource.com/chromium/src/+/c4f60b915d897050dac3d7532ff8c1e0139c1821
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
mikecase@chromium.org changed reviewers: + yolandyan@chromium.org
The table rows will inherit the vertical-align style and everything looks better
The CQ bit was checked by mikecase@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
ping
jbudorick@chromium.org changed reviewers: + jbudorick@chromium.org
lgtm
lgtm
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495058233204310, "parent_rev":
"fc66094f89df0ecca2a3378296304a9c7e66bbff", "commit_rev":
"c4f60b915d897050dac3d7532ff8c1e0139c1821"}
Message was sent while issue was closed.
Description was changed from ========== Add vertical-align:top to render test images. This fixes the alignment for when the render test images are a different size than the golden image. The images are compared by lining up the top-left corner. Setting vertical-align:top makes it easier to visualize how the diff image was constructed in this case. ========== to ========== Add vertical-align:top to render test images. This fixes the alignment for when the render test images are a different size than the golden image. The images are compared by lining up the top-left corner. Setting vertical-align:top makes it easier to visualize how the diff image was constructed in this case. Review-Url: https://codereview.chromium.org/2884833002 Cr-Commit-Position: refs/heads/master@{#472616} Committed: https://chromium.googlesource.com/chromium/src/+/c4f60b915d897050dac3d7532ff8... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c4f60b915d897050dac3d7532ff8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
