[Sync] Check that user is signed out before AndroidSyncSettingsTest

[Sync] Check that user is signed out before AndroidSyncSettingsTest

After the last round of failures I suspect that user is signed in before the
test which causes mAccount to be set to valid reference in
AndroidSyncSettings.ctor and respectively causes updateSyncability to skip
updating mSyncContentResolverDelegate.

R=skym@chromium.org
BUG=717960
Review-Url: https://codereview.chromium.org/2884823002
Cr-Commit-Position: refs/heads/master@{#471953}
Committed: https://chromium.googlesource.com/chromium/src/+/6bbc32fc27c0b7eb6fb416fe65ead0cefdcf6f13

[pavely, 2017-05-15 21:16:11]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 21:17:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-05-15 22:10:35]

lgtm

https://codereview.chromium.org/2884823002/diff/1/components/sync/android/jav...
File
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java
(right):

https://codereview.chromium.org/2884823002/diff/1/components/sync/android/jav...
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java:112:
assertFalse(ChromeSigninController.get().isSignedIn());
Should we be able to assertTrue(ChromeSigninController.get().isSignedIn());
later in this method?

[commit-bot: I haz the power, 2017-05-15 23:01:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:01:38]

Dry run: This issue passed the CQ dry run.

[pavely, 2017-05-15 23:48:48]

https://codereview.chromium.org/2884823002/diff/1/components/sync/android/jav...
File
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java
(right):

https://codereview.chromium.org/2884823002/diff/1/components/sync/android/jav...
components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java:112:
assertFalse(ChromeSigninController.get().isSignedIn());
On 2017/05/15 22:10:35, skym wrote:
> Should we be able to assertTrue(ChromeSigninController.get().isSignedIn());
> later in this method?

No, AndroidSyncSettings reads signed in user from ChromeSigninController, but
doesn't modify it. Better idea would be to inject fake ChromeSigninController
into AndroidSyncSettings, but that's not how the code is setup right now.

In this change I'm trying to prove that interaction with ChromeSigninController
causes test failure. If my guess is confirmed I'll figure out how to fix it.

[pavely, 2017-05-15 23:48:51]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:49:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 00:07:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494892131554180, "parent_rev":
"b717e22b72275498d43183016392b2ae0a011b3e", "commit_rev":
"6bbc32fc27c0b7eb6fb416fe65ead0cefdcf6f13"}

[commit-bot: I haz the power, 2017-05-16 00:07:33]

Description was changed from

==========
[Sync] Check that user is signed out before AndroidSyncSettingsTest

After the last round of failures I suspect that user is signed in before the
test which causes mAccount to be set to valid reference in
AndroidSyncSettings.ctor and respectively causes updateSyncability to skip
updating mSyncContentResolverDelegate.

R=skym@chromium.org
BUG=717960
==========

to

==========
[Sync] Check that user is signed out before AndroidSyncSettingsTest

After the last round of failures I suspect that user is signed in before the
test which causes mAccount to be set to valid reference in
AndroidSyncSettings.ctor and respectively causes updateSyncability to skip
updating mSyncContentResolverDelegate.

R=skym@chromium.org
BUG=717960

Review-Url: https://codereview.chromium.org/2884823002
Cr-Commit-Position: refs/heads/master@{#471953}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bbc32fc27c0b7eb6fb416fe65ea...
==========

[commit-bot: I haz the power, 2017-05-16 00:07:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6bbc32fc27c0b7eb6fb416fe65ea...