[subresource_filter] Add custom strings/behavior on Desktop Page Info

components/page_info_strings.grdp

Index: components/page_info_strings.grdp
diff --git a/components/page_info_strings.grdp b/components/page_info_strings.grdp
index f1af7c44018c98eeb738cc6587cd787780207a36..2028587b82c6a4857fe7ff1a276067ff1c7fafa6 100644
--- a/components/page_info_strings.grdp
+++ b/components/page_info_strings.grdp
@@ -260,6 +260,9 @@
     <message name="IDS_PAGE_INFO_MENU_ITEM_DETECT_IMPORTANT_CONTENT" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to detect important content.">
       Always detect important content on this site
     </message>
+    <message name="IDS_PAGE_INFO_SUBRESOURCE_FILTER_BLOCK" desc="The text of the menu item of a permissions menu on the Page Info UI for the subresource filter permission in Block mode" translateable="false">

[lgarron, 2017/05/17 20:16:45]

I don't think we should use translateable="false" to indicate a placeholder.
That invites shipping a mistake.
(Also, since it matches IDS_PAGE_INFO_MENU_ITEM_BLOCK and there isn't a
`meaning` attribute, it incurs zero translation cost.)

Could we instead add a comment above it?
<!-- IDS_PAGE_INFO_SUBRESOURCE_FILTER_BLOCK is currently the same as
IDS_PAGE_INFO_MENU_ITEM_BLOCK, but we use a different string identifier in the
code for the flexibility to change it in the future. -->

Also, I know I didn't point it out before, but nit:
IDS_PAGE_INFO_MENU_ITEM_SUBRESOURCE_FILTER_BLOCK would be more consistent with
the other strings.

[Charlie Harrison, 2017/05/17 20:26:03]

Sure, Done.
Done, thanks

+      Always block on this site
+    </message>
 
     <!-- UI for device access granted to the site using the device chooser (e.g. USB, Bluetooth) -->
     <message name="IDS_PAGE_INFO_USB_DEVICE_LABEL" desc="The label used to describe a USB device that the user has granted the site permission to access.">