[subresource_filter] Add custom strings/behavior on Desktop Page Info

components/page_info_strings.grdp

 <?xml version="1.0" encoding="utf-8"?>
 <grit-part>
   <!-- Security summary strings -->
   <!-- TODO(crbug.com/716305): Rename remaining IDS_PAGE_INFO_* strings to IDS_PAGE_INFO_* -->
   <message name="IDS_PAGE_INFO_SECURE_SUMMARY" desc="A short summary phrase at the top of the Page Info bubble (which shows when you click the lock icon) that indicates that the connection to the current website is secure.">
     Secure connection
   </message>
   <message name="IDS_PAGE_INFO_MIXED_CONTENT_SUMMARY" desc="A one-line summary at the top of the Page Info bubble (which shows when you click the security indicator) if the connection to the current website is using mainly using a secure connection but has some insecure parts (like insecurely loaded images).">
     Your connection to this site is not fully secure
   </message>
@@ skipping 242 matching lines @@
 
     <message name="IDS_PAGE_INFO_MENU_ITEM_ALLOW" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to allow.">
       Always allow on this site
     </message>
     <message name="IDS_PAGE_INFO_MENU_ITEM_BLOCK" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to allow.">
       Always block on this site
     </message>
     <message name="IDS_PAGE_INFO_MENU_ITEM_DETECT_IMPORTANT_CONTENT" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to detect important content.">
       Always detect important content on this site
     </message>
+    <message name="IDS_PAGE_INFO_SUBRESOURCE_FILTER_BLOCK" desc="The text of the menu item of a permissions menu on the Page Info UI for the subresource filter permission in Block mode" translateable="false">

[lgarron, 2017/05/17 20:16:45]

I don't think we should use translateable="false" to indicate a placeholder.
That invites shipping a mistake.
(Also, since it matches IDS_PAGE_INFO_MENU_ITEM_BLOCK and there isn't a
`meaning` attribute, it incurs zero translation cost.)

Could we instead add a comment above it?
<!-- IDS_PAGE_INFO_SUBRESOURCE_FILTER_BLOCK is currently the same as
IDS_PAGE_INFO_MENU_ITEM_BLOCK, but we use a different string identifier in the
code for the flexibility to change it in the future. -->

Also, I know I didn't point it out before, but nit:
IDS_PAGE_INFO_MENU_ITEM_SUBRESOURCE_FILTER_BLOCK would be more consistent with
the other strings.

[Charlie Harrison, 2017/05/17 20:26:03]

Sure, Done.
Done, thanks

+      Always block on this site
+    </message>
 
     <!-- UI for device access granted to the site using the device chooser (e.g. USB, Bluetooth) -->
     <message name="IDS_PAGE_INFO_USB_DEVICE_LABEL" desc="The label used to describe a USB device that the user has granted the site permission to access.">
       <ph name="DEVICE_NAME">$1<ex>Android Phone</ex></ph>
     </message>
     <message name="IDS_PAGE_INFO_DELETE_USB_DEVICE" desc="The tooltip displayed when hovering over the button that will remove permission to access a USB device that the user previously granted to the site.">
       Revoke access
     </message>
 
     <!-- Site settings link -->
@@ skipping 36 matching lines @@
 
     <!-- WebVR -->
     <message name="IDS_PAGE_INFO_INSECURE_WEBVR_CONTENT_TRANSIENT" desc="Text that is displayed temporarily as a large toast on first entering a WebVR page over non-secure transport.">
       Your connection to this site is not private. To exit VR mode at any time, remove headset and press back.
     </message>
     <message name="IDS_PAGE_INFO_INSECURE_WEBVR_CONTENT_PERMANENT" desc="Text that is displayed in a small permanent notification on a WebVR page loaded over non-secure transport. (Should be short, does not need to be a complete sentence.)">
       Not secure
     </message>
   </if>
 </grit-part>