[subresource_filter] Add custom strings/behavior on Desktop Page Info

components/page_info_strings.grdp

Index: components/page_info_strings.grdp
diff --git a/components/page_info_strings.grdp b/components/page_info_strings.grdp
index f1af7c44018c98eeb738cc6587cd787780207a36..206c16dd01b7012b2c5bf158e104f8c086978d30 100644
--- a/components/page_info_strings.grdp
+++ b/components/page_info_strings.grdp
@@ -260,6 +260,12 @@
     <message name="IDS_PAGE_INFO_MENU_ITEM_DETECT_IMPORTANT_CONTENT" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to detect important content.">
       Always detect important content on this site
     </message>
+    <message name="IDS_PAGE_INFO_SUBRESOURCE_FILTER_ALLOW" desc="The text of the menu item of a permissions menu on the Page Info UI for the subresource filter permission in Allow mode" translateable="false">

[lgarron, 2017/05/16 20:59:35]

Is this meant to be translateable="false"?

Also, I'm wondering why the strings are so long. Why can't we just use "Allow"
and "Block" like we do for other permissions with the same meaning?

(We used to have longer strings, but shortened them to make Page UI simpler.)

[Charlie Harrison, 2017/05/16 21:04:42]

These are the menu elements, which currently match the existing menu element
strings (IDS_PAGE_INFO_MENU_ITEM_ALLOW). I've matched them exactly here to use
them as placeholders, with translateable=false because these aren't the final
strings.

The string when the menu element is selected will still be "Allow" or "Block",
just not when the menu is expanded. 

[raymes, 2017/05/17 00:39:12]

I chatted with lgarron offline and he was thinking of the strings in the
drop-down for harmony (which I have been mentioning). Once we switch to harmony
we can just use Allow/Block in the drop down for everything (including this
setting).

[Charlie Harrison, 2017/05/17 14:06:07]

Acknowledged.

+      Always allow on this site
+    </message>
+    <message name="IDS_PAGE_INFO_SUBRESOURCE_FILTER_BLOCK" desc="The text of the menu item of a permissions menu on the Page Info UI for the subresource filter permission in Block mode" translateable="false">
+      Always block on this site
+    </message>
 
     <!-- UI for device access granted to the site using the device chooser (e.g. USB, Bluetooth) -->
     <message name="IDS_PAGE_INFO_USB_DEVICE_LABEL" desc="The label used to describe a USB device that the user has granted the site permission to access.">