[subresource_filter] Add custom strings/behavior on Desktop Page Info

components/page_info_strings.grdp

 <?xml version="1.0" encoding="utf-8"?>
 <grit-part>
   <!-- Security summary strings -->
   <!-- TODO(crbug.com/716305): Rename remaining IDS_PAGE_INFO_* strings to IDS_PAGE_INFO_* -->
   <message name="IDS_PAGE_INFO_SECURE_SUMMARY" desc="A short summary phrase at the top of the Page Info bubble (which shows when you click the lock icon) that indicates that the connection to the current website is secure.">
     Secure connection
   </message>
   <message name="IDS_PAGE_INFO_MIXED_CONTENT_SUMMARY" desc="A one-line summary at the top of the Page Info bubble (which shows when you click the security indicator) if the connection to the current website is using mainly using a secure connection but has some insecure parts (like insecurely loaded images).">
     Your connection to this site is not fully secure
   </message>
@@ skipping 242 matching lines @@
 
     <message name="IDS_PAGE_INFO_MENU_ITEM_ALLOW" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to allow.">
       Always allow on this site
     </message>
     <message name="IDS_PAGE_INFO_MENU_ITEM_BLOCK" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to allow.">
       Always block on this site
     </message>
     <message name="IDS_PAGE_INFO_MENU_ITEM_DETECT_IMPORTANT_CONTENT" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to detect important content.">
       Always detect important content on this site
     </message>
+    <message name="IDS_PAGE_INFO_SUBRESOURCE_FILTER_ALLOW" desc="The text of the menu item of a permissions menu on the Page Info UI for the subresource filter permission in Allow mode" translateable="false">

[lgarron, 2017/05/16 20:59:35]

Is this meant to be translateable="false"?

Also, I'm wondering why the strings are so long. Why can't we just use "Allow"
and "Block" like we do for other permissions with the same meaning?

(We used to have longer strings, but shortened them to make Page UI simpler.)

[Charlie Harrison, 2017/05/16 21:04:42]

These are the menu elements, which currently match the existing menu element
strings (IDS_PAGE_INFO_MENU_ITEM_ALLOW). I've matched them exactly here to use
them as placeholders, with translateable=false because these aren't the final
strings.

The string when the menu element is selected will still be "Allow" or "Block",
just not when the menu is expanded. 

[raymes, 2017/05/17 00:39:12]

I chatted with lgarron offline and he was thinking of the strings in the
drop-down for harmony (which I have been mentioning). Once we switch to harmony
we can just use Allow/Block in the drop down for everything (including this
setting).

[Charlie Harrison, 2017/05/17 14:06:07]

Acknowledged.

+      Always allow on this site
+    </message>
+    <message name="IDS_PAGE_INFO_SUBRESOURCE_FILTER_BLOCK" desc="The text of the menu item of a permissions menu on the Page Info UI for the subresource filter permission in Block mode" translateable="false">
+      Always block on this site
+    </message>
 
     <!-- UI for device access granted to the site using the device chooser (e.g. USB, Bluetooth) -->
     <message name="IDS_PAGE_INFO_USB_DEVICE_LABEL" desc="The label used to describe a USB device that the user has granted the site permission to access.">
       <ph name="DEVICE_NAME">$1<ex>Android Phone</ex></ph>
     </message>
     <message name="IDS_PAGE_INFO_DELETE_USB_DEVICE" desc="The tooltip displayed when hovering over the button that will remove permission to access a USB device that the user previously granted to the site.">
       Revoke access
     </message>
 
     <!-- Site settings link -->
@@ skipping 36 matching lines @@
 
     <!-- WebVR -->
     <message name="IDS_PAGE_INFO_INSECURE_WEBVR_CONTENT_TRANSIENT" desc="Text that is displayed temporarily as a large toast on first entering a WebVR page over non-secure transport.">
       Your connection to this site is not private. To exit VR mode at any time, remove headset and press back.
     </message>
     <message name="IDS_PAGE_INFO_INSECURE_WEBVR_CONTENT_PERMANENT" desc="Text that is displayed in a small permanent notification on a WebVR page loaded over non-secure transport. (Should be short, does not need to be a complete sentence.)">
       Not secure
     </message>
   </if>
 </grit-part>