[subresource_filter] Add custom strings/behavior on Desktop Page Info

chrome/browser/ui/page_info/page_info_ui.cc

Index: chrome/browser/ui/page_info/page_info_ui.cc
diff --git a/chrome/browser/ui/page_info/page_info_ui.cc b/chrome/browser/ui/page_info/page_info_ui.cc
index 401b5cd12f5307c98b44dc619dbf3c8189db364e..5d4c6b539265bc5cb745e2506bf70de95ea08771 100644
--- a/chrome/browser/ui/page_info/page_info_ui.cc
+++ b/chrome/browser/ui/page_info/page_info_ui.cc
@@ -288,6 +288,10 @@ base::string16 PageInfoUI::PermissionActionToUIString(
       NOTREACHED();
       return base::string16();
   }
+  // The subresource filter permission uses the user managed strings
+  // (i.e. Allow / Block).
+  if (type == CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER)
+    button_text_ids = kPermissionButtonTextIDUserManaged;

[raymes, 2017/05/15 23:41:21]

nit: Is this needed? I don't think the source could ever be anything other than
a user-sourced setting.

[raymes, 2017/05/15 23:43:39]

Oh I see - you're avoiding the default case, nevermind.

[Charlie Harrison, 2017/05/16 01:47:26]

Acknowledged.

   int button_text_id = button_text_ids[effective_setting];
   DCHECK_NE(button_text_id, kInvalidResourceID);
   return l10n_util::GetStringUTF16(button_text_id);