[subresource_filter] Add custom strings/behavior on Desktop Page Info

chrome/browser/ui/page_info/page_info_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/page_info/page_info_ui.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 270 matching lines @@
     case content_settings::SETTING_SOURCE_POLICY:
     case content_settings::SETTING_SOURCE_EXTENSION:
       button_text_ids = kPermissionButtonTextIDUserManaged;
       break;
     case content_settings::SETTING_SOURCE_WHITELIST:
     case content_settings::SETTING_SOURCE_NONE:
     default:
       NOTREACHED();
       return base::string16();
   }
+  // The subresource filter permission uses the user managed strings
+  // (i.e. Allow / Block).
+  if (type == CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER)
+    button_text_ids = kPermissionButtonTextIDUserManaged;

[raymes, 2017/05/15 23:41:21]

nit: Is this needed? I don't think the source could ever be anything other than
a user-sourced setting.

[raymes, 2017/05/15 23:43:39]

Oh I see - you're avoiding the default case, nevermind.

[Charlie Harrison, 2017/05/16 01:47:26]

Acknowledged.

   int button_text_id = button_text_ids[effective_setting];
   DCHECK_NE(button_text_id, kInvalidResourceID);
   return l10n_util::GetStringUTF16(button_text_id);
 }
 
 // static
 int PageInfoUI::GetPermissionIconID(ContentSettingsType type,
                                     ContentSetting setting) {
   bool use_blocked = (setting == CONTENT_SETTING_BLOCK);
   for (const PermissionsUIInfo& info : kPermissionsUIInfo) {
@@ skipping 137 matching lines @@
 const gfx::ImageSkia PageInfoUI::GetCertificateIcon() {
   return gfx::CreateVectorIcon(kCertificateIcon, 16, gfx::kChromeIconGrey);
 }
 #endif
 
 // static
 bool PageInfoUI::ShouldShowCertificateLink() {
   return base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kShowCertLink);
 }