Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2884743002: Fix timing bug in delayed async initialization on Android. (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
Reviewers:
Theresa, Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix timing bug in delayed async initialization on Android. When deferring the init of the native libraries, it adjusted the timing when the draw observer that kicks off the native load is registered. Because it was delayed, the first draw of the view might have already happened and as a result the native library would be blocked indefinitely until another draw occurred (which wouldn't happen unless the user rotated the phone or otherwise was able to trigger a redraw). The moves back to using the bulk of the shared pre-native startup code and defers signally the draw actually happened until the embedding code signals that the startup should proceed. BUG=721868 Review-Url: https://codereview.chromium.org/2884743002 Cr-Commit-Position: refs/heads/master@{#472145} Committed: https://chromium.googlesource.com/chromium/src/+/a9935effb606cac69554673147c9bfc6484b0b9c

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
Ted C
twellington@ - PTAL yusufo@ - FYI and PTAL upon return
3 years, 7 months ago (2017-05-15 17:54:32 UTC) #2
Theresa
lgtm % typo "timinig" in commit message
3 years, 7 months ago (2017-05-15 20:02:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884743002/1
3 years, 7 months ago (2017-05-16 16:39:38 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 17:25:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9935effb606cac69554673147c9...

Powered by Google App Engine
This is Rietveld 408576698