Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2884733003: Remove a duplicate and leaking test LayoutTableCellTest.AbsoluteColumnIndex (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
wkorman
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a duplicate and leaking test LayoutTableCellTest.AbsoluteColumnIndex The test leaks the cell. Remove it instead of fixing it because there have been other tests (LayoutTableCellDeathTest.*) testing the same thing. BUG=721932 Review-Url: https://codereview.chromium.org/2884733003 Cr-Commit-Position: refs/heads/master@{#471970} Committed: https://chromium.googlesource.com/chromium/src/+/8ba6e31c50feaa168f08fc02fd2e467d3f64836d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Xianzhu
3 years, 7 months ago (2017-05-15 21:12:12 UTC) #2
wkorman
lgtm
3 years, 7 months ago (2017-05-16 00:30:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884733003/1
3 years, 7 months ago (2017-05-16 00:33:27 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 01:22:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ba6e31c50feaa168f08fc02fd2e...

Powered by Google App Engine
This is Rietveld 408576698