Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2884723002: [ObjC ARC] Converts ios/chrome/browser/autofill:eg_tests to ARC. (Closed)

Created:
3 years, 7 months ago by baxley
Modified:
3 years, 7 months ago
Reviewers:
Justin Donnelly
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, stkhapugin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/autofill:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2884723002 Cr-Commit-Position: refs/heads/master@{#472318} Committed: https://chromium.googlesource.com/chromium/src/+/29c52e534042bff7e45c4a2784d7f4922885b12a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/chrome/browser/autofill/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/autofill/form_input_egtest.mm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
baxley
3 years, 7 months ago (2017-05-15 17:30:54 UTC) #4
baxley
CC Stepan for ARC
3 years, 7 months ago (2017-05-15 18:40:43 UTC) #5
Justin Donnelly
lgtm
3 years, 7 months ago (2017-05-15 23:53:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884723002/1
3 years, 7 months ago (2017-05-16 17:39:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/428124)
3 years, 7 months ago (2017-05-16 21:02:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884723002/1
3 years, 7 months ago (2017-05-16 21:10:29 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 04:14:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29c52e534042bff7e45c4a2784d7...

Powered by Google App Engine
This is Rietveld 408576698