Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2884713002: Add keyLocation to KeyboardEvent constructor for backwards compatibility (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add keyLocation to KeyboardEvent constructor for backwards compatibility BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/35979c32058f5ab2d9fa8d3db853403f9486f951

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 1 chunk +11 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate View 1 chunk +11 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 7 months ago (2017-05-15 17:05:22 UTC) #2
Jacob
lgtm Thanks for adding this back in! https://codereview.chromium.org/2884713002/diff/1/tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate File tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate (right): https://codereview.chromium.org/2884713002/diff/1/tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate#newcode14 tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate:14: int keyLocation, ...
3 years, 7 months ago (2017-05-15 17:12:06 UTC) #3
sra1
3 years, 7 months ago (2017-05-15 17:58:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
35979c32058f5ab2d9fa8d3db853403f9486f951 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698