sdk/lib/html/dart2js/html_dart2js.dart - Issue 2884713002: Add keyLocation to KeyboardEvent constructor for backwards compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 2884713002: Add keyLocation to KeyboardEvent constructor for backwards compatibility (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 83571d18cdcff9450cbba9db13d408c663464083..8d240427c81fa2b847d98bb74ed4034c512f9e00 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -22074,7 +22074,8 @@ class KeyboardEvent extends UIEvent {

{Window view,

bool canBubble: true,

bool cancelable: true,

- int location: 1,

+ int location,

+ int keyLocation, // Legacy alias for location

bool ctrlKey: false,

bool altKey: false,

bool shiftKey: false,

@@ -22082,6 +22083,7 @@ class KeyboardEvent extends UIEvent {

if (view == null) {

view = window;

}

+ location ??= keyLocation ?? 1;

KeyboardEvent e = document._createEvent("KeyboardEvent");

e._initKeyboardEvent(type, canBubble, cancelable, view, "", location,

ctrlKey, altKey, shiftKey, metaKey);